Add labels to indicate availability for other arches #768
Conversation
|
Thanks @manojnkumar ! |
openshift-ci
bot
added
the
do-not-merge/hold
|
/retest |
| @@ -167,6 +167,11 @@ metadata: | |||
| support: Red Hat Inc. | |||
| name: compliance-operator.v0.1.47 | |||
| namespace: placeholder | |||
| labels: | |||
| operatorframework.io/arch.amd64: supported | |||
| operatorframework.io/arch.arm64: supported | |||
There was a problem hiding this comment.
We'd love to have compliance operator for ARM too, but currently it's not being built (downstream) so it MUST NOT be included here.
There was a problem hiding this comment.
Oh good catch, this should be corrected.
There was a problem hiding this comment.
OK, Dropped arm64.
|
/retest |
|
The change looks good for downstream, but will this also affect the upstream (community) version as well? The community build is still amd64-only so it shouldn't have these flags. Can these be separated somehow? |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
It could be separated. We'd have to code the labels to the CSV when the downstream bundle repo's I'm not sure how common it is to use OLM to install the upstream version, as opposed to using deploy/ directly. It's provided as a courtesy for upstream, but In general, we treat the CSV as a downstream component (some of the elements like the variable names "RELATED_IMAGE_" are downstream specific). Overall I'm inclined to have the labels here upstream so they are sourced directly downstream, and to avoid confusion, Add a comment / document that only amd64 builds are provided upstream, even though the labels are there. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: manojnkumar, mrogers950 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
|
@manojnkumar: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
PR-795 to be able to build the |
|
/cherry-pick release-v0.1.48 |
|
@yselkowitz: new pull request created: #806 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We have done the validation for the ocp4-cis and ocp4-cis-node profiles on ppc64le and are ready to for this operator to be supported on this architecture.