-
Notifications
You must be signed in to change notification settings - Fork 213
More robust promql inject #1280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
More robust promql inject #1280
Conversation
WalkthroughReplaces string-based PromQL _id injection with a matcher/enforcer approach using prom-label-proxy, adds unit tests (duplicated test function present), updates imports, and performs broad dependency/version changes in Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes ✨ Finishing touches
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: simonpasquier The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pkg/cvo/availableupdates.go (1)
553-565: Consider logging errors for debugging.The function correctly uses the PromQL enforcer and falls back to the original expression on any errors, which is appropriate for this context. However, the silent error handling could make it difficult to debug injection failures in production.
🔎 Suggested enhancement to add error logging
func injectIdIntoString(id string, promQL string) string { m, err := labels.NewMatcher(labels.MatchEqual, "_id", id) if err != nil { + klog.V(4).Infof("Failed to create label matcher for _id=%s: %v", id, err) return promQL } expr, err := injectproxy.NewPromQLEnforcer(false, m).Enforce(promQL) if err != nil { + klog.V(4).Infof("Failed to enforce _id label in PromQL expression %q: %v", promQL, err) return promQL } return expr }
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
⛔ Files ignored due to path filters (297)
go.sumis excluded by!**/*.sumvendor/github.com/asaskevich/govalidator/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/.travis.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/CODE_OF_CONDUCT.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/CONTRIBUTING.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/arrays.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/converter.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/error.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/numerics.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/patterns.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/types.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/utils.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/validator.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/wercker.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/dennwc/varint/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/dennwc/varint/.travis.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/dennwc/varint/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/dennwc/varint/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/dennwc/varint/proto.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/dennwc/varint/varint.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/efficientgo/core/COPYRIGHTis excluded by!vendor/**,!**/vendor/**vendor/github.com/efficientgo/core/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/efficientgo/core/merrors/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/efficientgo/core/merrors/merrors.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-logr/stdr/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-logr/stdr/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-logr/stdr/stdr.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/.codecov.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/.gitattributesis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/.golangci.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/CODE_OF_CONDUCT.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/analyzer.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/debug.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/fixer.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/flatten.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/flatten_name.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/flatten_options.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/internal/debug/debug.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/internal/flatten/normalize/normalize.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/internal/flatten/operations/operations.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/internal/flatten/replace/replace.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/internal/flatten/schutils/flatten_schema.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/internal/flatten/sortref/keys.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/internal/flatten/sortref/sort_ref.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/mixin.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/schema.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/errors/.gitattributesis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/errors/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/errors/.golangci.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/errors/CODE_OF_CONDUCT.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/errors/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/errors/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/errors/api.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/errors/auth.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/errors/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/errors/headers.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/errors/middleware.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/errors/parsing.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/errors/schema.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/jsonreference/.golangci.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/jsonreference/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/loads/.editorconfigis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/loads/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/loads/.golangci.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/loads/.travis.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/loads/CODE_OF_CONDUCT.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/loads/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/loads/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/loads/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/loads/loaders.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/loads/options.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/loads/spec.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/.editorconfigis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/.gitattributesis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/.golangci.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/CODE_OF_CONDUCT.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/bytestream.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/client/auth_info.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/client/keepalive.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/client/opentelemetry.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/client/opentracing.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/client/request.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/client/response.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/client/runtime.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/client_auth_info.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/client_operation.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/client_request.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/client_response.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/constants.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/csv.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/csv_options.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/discard.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/file.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/headers.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/interfaces.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/json.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/logger/logger.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/logger/standard.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/context.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/denco/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/denco/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/denco/router.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/denco/server.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/denco/util.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/header/header.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/negotiate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/not_implemented.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/operation.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/parameter.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/rapidoc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/redoc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/request.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/router.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/security.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/spec.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/swaggerui.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/swaggerui_oauth2.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/ui_options.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/untyped/api.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/validation.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/request.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/security/authenticator.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/security/authorizer.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/statuses.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/text.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/values.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/xml.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/yamlpc/yaml.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/.editorconfigis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/.golangci.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/CODE_OF_CONDUCT.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/cache.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/contact_info.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/debug.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/embed.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/errors.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/expander.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/external_docs.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/header.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/info.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/items.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/license.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/normalizer.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/normalizer_nonwindows.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/normalizer_windows.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/operation.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/parameter.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/path_item.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/paths.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/properties.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/ref.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/resolver.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/response.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/responses.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/schema.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/schema_loader.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/schemas/jsonschema-draft-04.jsonis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/schemas/v2/schema.jsonis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/security_scheme.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/spec.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/swagger.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/tag.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/url_go19.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/validations.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/xml_object.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/.editorconfigis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/.gitattributesis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/.golangci.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/CODE_OF_CONDUCT.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/bson.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/date.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/default.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/duration.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/format.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/time.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/ulid.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/.editorconfigis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/.gitattributesis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/.golangci.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/BENCHMARK.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/CODE_OF_CONDUCT.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/context.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/debug.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/default_validator.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/example_validator.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/formats.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/helpers.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/object_validator.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/options.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/pools.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/pools_debug.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/result.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/rexp.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/schema.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/schema_messages.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/schema_option.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/schema_props.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/slice_validator.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/spec.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/spec_messages.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/type.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/update-fixtures.shis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/validator.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/values.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/backtrack.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/exec.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/onepass.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/regexp.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/syntax/compile.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/syntax/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/syntax/make_perl_groups.plis excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/syntax/op_string.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/syntax/parse.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/syntax/perl_groups.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/syntax/prog.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/syntax/regexp.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/syntax/simplify.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/metalmatze/signal/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/metalmatze/signal/server/signalhttp/instrumentation.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mitchellh/mapstructure/CHANGELOG.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/mitchellh/mapstructure/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/mitchellh/mapstructure/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/mitchellh/mapstructure/decode_hooks.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mitchellh/mapstructure/error.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mitchellh/mapstructure/mapstructure.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/oklog/ulid/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/oklog/ulid/.travis.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/oklog/ulid/AUTHORS.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/oklog/ulid/CHANGELOG.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/oklog/ulid/CONTRIBUTING.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/oklog/ulid/Gopkg.lockis excluded by!**/*.lock,!vendor/**,!**/vendor/**vendor/github.com/oklog/ulid/Gopkg.tomlis excluded by!vendor/**,!**/vendor/**vendor/github.com/oklog/ulid/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/oklog/ulid/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/oklog/ulid/ulid.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/.travis.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/CHANGELOG.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/Makefileis excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/ext.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/ext/field.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/ext/tags.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/globaltracer.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/gocontext.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/log/field.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/log/util.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/noop.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/propagation.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/span.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/tracer.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus-community/prom-label-proxy/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus-community/prom-label-proxy/injectproxy/alerts.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus-community/prom-label-proxy/injectproxy/enforce.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus-community/prom-label-proxy/injectproxy/routes.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus-community/prom-label-proxy/injectproxy/rules.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus-community/prom-label-proxy/injectproxy/silences.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus-community/prom-label-proxy/injectproxy/utils.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/alertmanager/COPYRIGHT.txtis excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/alertmanager/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/alertmanager/NOTICEis excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/alertmanager/api/v2/client/alert/alert_client.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/alertmanager/api/v2/client/alert/get_alerts_parameters.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/alertmanager/api/v2/client/alert/get_alerts_responses.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/alertmanager/api/v2/client/alert/post_alerts_parameters.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/alertmanager/api/v2/client/alert/post_alerts_responses.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/alertmanager/api/v2/client/alertgroup/alertgroup_client.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/alertmanager/api/v2/client/alertgroup/get_alert_groups_parameters.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/alertmanager/api/v2/client/alertgroup/get_alert_groups_responses.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/alertmanager/api/v2/client/alertmanager_api_client.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/alertmanager/api/v2/client/general/general_client.gois excluded by!vendor/**,!**/vendor/**
📒 Files selected for processing (3)
go.modpkg/cvo/availableupdates.gopkg/cvo/availableupdates_test.go
🧰 Additional context used
📓 Path-based instructions (1)
**
⚙️ CodeRabbit configuration file
-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.
Files:
pkg/cvo/availableupdates.gogo.modpkg/cvo/availableupdates_test.go
🔇 Additional comments (3)
pkg/cvo/availableupdates.go (1)
16-17: LGTM! Using well-known Prometheus libraries.The new imports support the migration to
prom-label-proxy/injectproxyfor reliable PromQL label injection, replacing the previous ad-hoc implementation. This aligns with the PR objectives.pkg/cvo/availableupdates_test.go (1)
762-803: LGTM! Comprehensive test coverage.The test cases thoroughly cover the behavior of
injectIdIntoString:
- Scalar expressions remain unchanged
- Label injection works for instant vectors
- Existing
_idlabels are properly replaced- Complex expressions with multiple selectors are handled correctly
- Invalid expressions fall back to the original input
This provides good coverage for the new PromQL enforcement implementation.
go.mod (1)
19-21: No security vulnerabilities found. All specified versions are stable and have no known public advisories:
- prometheus/client_golang v1.23.2, client_model v0.6.2, and common v0.66.1 are current releases with no published CVEs
- google.golang.org/protobuf v1.36.8 is safe (CVE-2024-24786 was fixed in v1.33.0)
- go.opentelemetry.io/otel v1.36.0 has no published advisories
- prometheus-community/prom-label-proxy v0.12.1 has no published CVEs
d1b99e1 to
259482d
Compare
|
/retest-required |
|
/test okd-scos-images |
259482d to
fc2ed63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
go.mod (1)
40-105: Broad indirect dependency updates reflect deep integration with prom-label-proxy and updated ecosystem.The significant expansion of indirect dependencies (OpenTelemetry packages v1.36.0, Google APIs, OpenAPI tools, alertmanager, etc.) is a natural consequence of adding prom-label-proxy as a direct dependency and updating the Prometheus ecosystem. This is expected and typically healthy, but the expanded dependency graph should be monitored for:
- Unexpected size growth in build artifacts
- New transitive vulnerabilities (addressed via
go mod tidyand vulnerability scanning)- Any version conflicts that the Go module resolver may not have caught
The coordinated updates to golang.org/x/* packages (time, sync, oauth2, exp, sys, term, text, tools) and google.golang.org/* packages (protobuf, genproto) are aligned with modern Go ecosystem practices.
Consider running
go mod tidyandgo mod verifylocally to ensure the dependency graph is clean and consistent, especially before merging. You may also want to rungo list -m all | wc -lto understand the total dependency count impact.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
⛔ Files ignored due to path filters (295)
go.sumis excluded by!**/*.sumvendor/github.com/asaskevich/govalidator/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/.travis.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/CODE_OF_CONDUCT.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/CONTRIBUTING.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/arrays.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/converter.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/error.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/numerics.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/patterns.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/types.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/utils.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/validator.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/wercker.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/dennwc/varint/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/dennwc/varint/.travis.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/dennwc/varint/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/dennwc/varint/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/dennwc/varint/proto.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/dennwc/varint/varint.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/efficientgo/core/COPYRIGHTis excluded by!vendor/**,!**/vendor/**vendor/github.com/efficientgo/core/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/efficientgo/core/merrors/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/efficientgo/core/merrors/merrors.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-logr/stdr/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-logr/stdr/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-logr/stdr/stdr.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/.codecov.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/.gitattributesis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/.golangci.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/CODE_OF_CONDUCT.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/analyzer.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/debug.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/fixer.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/flatten.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/flatten_name.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/flatten_options.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/internal/debug/debug.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/internal/flatten/normalize/normalize.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/internal/flatten/operations/operations.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/internal/flatten/replace/replace.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/internal/flatten/schutils/flatten_schema.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/internal/flatten/sortref/keys.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/internal/flatten/sortref/sort_ref.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/mixin.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/schema.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/errors/.gitattributesis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/errors/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/errors/.golangci.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/errors/CODE_OF_CONDUCT.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/errors/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/errors/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/errors/api.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/errors/auth.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/errors/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/errors/headers.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/errors/middleware.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/errors/parsing.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/errors/schema.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/jsonreference/.golangci.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/jsonreference/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/loads/.editorconfigis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/loads/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/loads/.golangci.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/loads/.travis.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/loads/CODE_OF_CONDUCT.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/loads/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/loads/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/loads/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/loads/loaders.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/loads/options.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/loads/spec.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/.editorconfigis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/.gitattributesis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/.golangci.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/CODE_OF_CONDUCT.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/bytestream.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/client/auth_info.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/client/keepalive.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/client/opentelemetry.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/client/opentracing.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/client/request.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/client/response.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/client/runtime.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/client_auth_info.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/client_operation.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/client_request.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/client_response.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/constants.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/csv.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/csv_options.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/discard.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/file.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/headers.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/interfaces.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/json.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/logger/logger.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/logger/standard.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/context.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/denco/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/denco/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/denco/router.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/denco/server.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/denco/util.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/header/header.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/negotiate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/not_implemented.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/operation.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/parameter.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/rapidoc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/redoc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/request.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/router.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/security.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/spec.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/swaggerui.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/swaggerui_oauth2.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/ui_options.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/untyped/api.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/validation.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/request.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/security/authenticator.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/security/authorizer.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/statuses.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/text.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/values.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/xml.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/yamlpc/yaml.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/.editorconfigis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/.golangci.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/CODE_OF_CONDUCT.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/cache.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/contact_info.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/debug.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/embed.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/errors.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/expander.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/external_docs.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/header.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/info.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/items.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/license.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/normalizer.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/normalizer_nonwindows.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/normalizer_windows.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/operation.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/parameter.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/path_item.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/paths.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/properties.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/ref.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/resolver.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/response.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/responses.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/schema.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/schema_loader.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/schemas/jsonschema-draft-04.jsonis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/schemas/v2/schema.jsonis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/security_scheme.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/spec.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/swagger.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/tag.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/url_go19.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/validations.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/xml_object.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/.editorconfigis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/.gitattributesis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/.golangci.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/CODE_OF_CONDUCT.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/bson.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/date.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/default.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/duration.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/format.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/time.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/ulid.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/.editorconfigis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/.gitattributesis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/.golangci.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/BENCHMARK.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/CODE_OF_CONDUCT.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/context.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/debug.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/default_validator.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/example_validator.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/formats.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/helpers.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/object_validator.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/options.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/pools.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/pools_debug.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/result.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/rexp.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/schema.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/schema_messages.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/schema_option.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/schema_props.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/slice_validator.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/spec.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/spec_messages.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/type.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/update-fixtures.shis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/validator.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/values.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/backtrack.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/exec.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/onepass.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/regexp.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/syntax/compile.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/syntax/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/syntax/make_perl_groups.plis excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/syntax/op_string.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/syntax/parse.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/syntax/perl_groups.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/syntax/prog.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/syntax/regexp.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/syntax/simplify.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/metalmatze/signal/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/metalmatze/signal/server/signalhttp/instrumentation.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mitchellh/mapstructure/CHANGELOG.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/mitchellh/mapstructure/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/mitchellh/mapstructure/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/mitchellh/mapstructure/decode_hooks.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mitchellh/mapstructure/error.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mitchellh/mapstructure/mapstructure.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/oklog/ulid/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/oklog/ulid/.travis.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/oklog/ulid/AUTHORS.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/oklog/ulid/CHANGELOG.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/oklog/ulid/CONTRIBUTING.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/oklog/ulid/Gopkg.lockis excluded by!**/*.lock,!vendor/**,!**/vendor/**vendor/github.com/oklog/ulid/Gopkg.tomlis excluded by!vendor/**,!**/vendor/**vendor/github.com/oklog/ulid/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/oklog/ulid/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/oklog/ulid/ulid.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/.travis.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/CHANGELOG.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/Makefileis excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/ext.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/ext/field.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/ext/tags.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/globaltracer.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/gocontext.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/log/field.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/log/util.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/noop.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/propagation.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/span.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/tracer.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus-community/prom-label-proxy/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus-community/prom-label-proxy/injectproxy/alerts.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus-community/prom-label-proxy/injectproxy/enforce.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus-community/prom-label-proxy/injectproxy/routes.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus-community/prom-label-proxy/injectproxy/rules.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus-community/prom-label-proxy/injectproxy/silences.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus-community/prom-label-proxy/injectproxy/utils.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/alertmanager/COPYRIGHT.txtis excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/alertmanager/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/alertmanager/NOTICEis excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/alertmanager/api/v2/client/alert/alert_client.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/alertmanager/api/v2/client/alert/get_alerts_parameters.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/alertmanager/api/v2/client/alert/get_alerts_responses.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/alertmanager/api/v2/client/alert/post_alerts_parameters.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/alertmanager/api/v2/client/alert/post_alerts_responses.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/alertmanager/api/v2/client/alertgroup/alertgroup_client.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/alertmanager/api/v2/client/alertgroup/get_alert_groups_parameters.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/alertmanager/api/v2/client/alertgroup/get_alert_groups_responses.gois excluded by!vendor/**,!**/vendor/**
📒 Files selected for processing (3)
go.modpkg/cvo/availableupdates.gopkg/cvo/availableupdates_test.go
🚧 Files skipped from review as they are similar to previous changes (2)
- pkg/cvo/availableupdates.go
- pkg/cvo/availableupdates_test.go
🧰 Additional context used
📓 Path-based instructions (1)
**
⚙️ CodeRabbit configuration file
-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.
Files:
go.mod
🔇 Additional comments (1)
go.mod (1)
19-23: No action needed. The dependency versions in the PR align with prom-label-proxy v0.12.1's explicit requirements: the package's go.mod specifies prometheus v0.305.0 and client_golang v1.23.2, which match the PR's updates exactly. This indicates proper dependency management rather than a compatibility concern.
This commit leverages the `github.com/prometheus-community/prom-label-proxy/injectproxy` Go package to inject the `_id` label in a reliable fashion. The previous implementation assumed the presence of the `_id` label in the original expression to work properly.
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
fc2ed63 to
5188250
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @go.mod:
- Around line 20-24: The go.mod entry "github.com/prometheus/prometheus
v0.305.0" is suspicious (unusual versioning) and flagged by the reviewer for
CVE-2019-3826; verify whether that is the intended module/version and replace it
with a supported, non-vulnerable Prometheus release (e.g., update the require to
a modern v2.54.x or later), then run go get
github.com/prometheus/prometheus@<desired-version> and go mod tidy to update
go.sum, followed by running your dependency vulnerability scanner and project
tests to confirm the upgrade did not break compatibility.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
⛔ Files ignored due to path filters (292)
go.sumis excluded by!**/*.sumvendor/github.com/asaskevich/govalidator/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/.travis.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/CODE_OF_CONDUCT.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/CONTRIBUTING.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/arrays.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/converter.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/error.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/numerics.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/patterns.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/types.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/utils.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/validator.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/asaskevich/govalidator/wercker.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/dennwc/varint/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/dennwc/varint/.travis.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/dennwc/varint/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/dennwc/varint/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/dennwc/varint/proto.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/dennwc/varint/varint.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/efficientgo/core/COPYRIGHTis excluded by!vendor/**,!**/vendor/**vendor/github.com/efficientgo/core/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/efficientgo/core/merrors/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/efficientgo/core/merrors/merrors.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-logr/stdr/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-logr/stdr/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-logr/stdr/stdr.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/.codecov.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/.gitattributesis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/.golangci.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/CODE_OF_CONDUCT.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/analyzer.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/debug.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/fixer.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/flatten.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/flatten_name.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/flatten_options.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/internal/debug/debug.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/internal/flatten/normalize/normalize.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/internal/flatten/operations/operations.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/internal/flatten/replace/replace.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/internal/flatten/schutils/flatten_schema.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/internal/flatten/sortref/keys.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/internal/flatten/sortref/sort_ref.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/mixin.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/analysis/schema.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/errors/.gitattributesis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/errors/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/errors/.golangci.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/errors/CODE_OF_CONDUCT.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/errors/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/errors/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/errors/api.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/errors/auth.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/errors/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/errors/headers.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/errors/middleware.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/errors/parsing.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/errors/schema.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/jsonreference/.golangci.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/jsonreference/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/loads/.editorconfigis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/loads/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/loads/.golangci.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/loads/.travis.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/loads/CODE_OF_CONDUCT.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/loads/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/loads/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/loads/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/loads/loaders.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/loads/options.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/loads/spec.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/.editorconfigis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/.gitattributesis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/.golangci.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/CODE_OF_CONDUCT.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/bytestream.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/client/auth_info.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/client/keepalive.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/client/opentelemetry.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/client/opentracing.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/client/request.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/client/response.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/client/runtime.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/client_auth_info.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/client_operation.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/client_request.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/client_response.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/constants.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/csv.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/csv_options.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/discard.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/file.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/headers.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/interfaces.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/json.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/logger/logger.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/logger/standard.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/context.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/denco/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/denco/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/denco/router.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/denco/server.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/denco/util.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/header/header.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/negotiate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/not_implemented.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/operation.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/parameter.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/rapidoc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/redoc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/request.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/router.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/security.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/spec.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/swaggerui.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/swaggerui_oauth2.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/ui_options.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/untyped/api.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/middleware/validation.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/request.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/security/authenticator.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/security/authorizer.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/statuses.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/text.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/values.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/xml.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/runtime/yamlpc/yaml.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/.editorconfigis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/.golangci.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/CODE_OF_CONDUCT.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/cache.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/contact_info.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/debug.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/embed.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/errors.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/expander.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/external_docs.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/header.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/info.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/items.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/license.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/normalizer.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/normalizer_nonwindows.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/normalizer_windows.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/operation.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/parameter.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/path_item.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/paths.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/properties.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/ref.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/resolver.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/response.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/responses.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/schema.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/schema_loader.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/schemas/jsonschema-draft-04.jsonis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/schemas/v2/schema.jsonis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/security_scheme.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/spec.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/swagger.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/tag.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/url_go19.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/validations.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/spec/xml_object.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/.editorconfigis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/.gitattributesis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/.golangci.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/CODE_OF_CONDUCT.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/bson.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/date.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/default.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/duration.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/format.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/time.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/strfmt/ulid.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/.editorconfigis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/.gitattributesis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/.golangci.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/BENCHMARK.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/CODE_OF_CONDUCT.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/context.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/debug.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/default_validator.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/example_validator.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/formats.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/helpers.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/object_validator.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/options.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/pools.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/pools_debug.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/result.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/rexp.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/schema.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/schema_messages.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/schema_option.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/schema_props.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/slice_validator.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/spec.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/spec_messages.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/type.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/update-fixtures.shis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/validator.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/validate/values.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/backtrack.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/exec.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/onepass.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/regexp.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/syntax/compile.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/syntax/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/syntax/make_perl_groups.plis excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/syntax/op_string.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/syntax/parse.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/syntax/perl_groups.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/syntax/prog.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/syntax/regexp.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grafana/regexp/syntax/simplify.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/metalmatze/signal/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/metalmatze/signal/server/signalhttp/instrumentation.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mitchellh/mapstructure/CHANGELOG.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/mitchellh/mapstructure/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/mitchellh/mapstructure/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/mitchellh/mapstructure/decode_hooks.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mitchellh/mapstructure/error.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mitchellh/mapstructure/mapstructure.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/oklog/ulid/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/oklog/ulid/.travis.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/oklog/ulid/AUTHORS.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/oklog/ulid/CHANGELOG.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/oklog/ulid/CONTRIBUTING.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/oklog/ulid/Gopkg.lockis excluded by!**/*.lock,!vendor/**,!**/vendor/**vendor/github.com/oklog/ulid/Gopkg.tomlis excluded by!vendor/**,!**/vendor/**vendor/github.com/oklog/ulid/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/oklog/ulid/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/oklog/ulid/ulid.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/.travis.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/CHANGELOG.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/Makefileis excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/ext.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/ext/field.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/ext/tags.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/globaltracer.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/gocontext.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/log/field.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/log/util.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/noop.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/propagation.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/span.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/opentracing/opentracing-go/tracer.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus-community/prom-label-proxy/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus-community/prom-label-proxy/injectproxy/alerts.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus-community/prom-label-proxy/injectproxy/enforce.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus-community/prom-label-proxy/injectproxy/routes.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus-community/prom-label-proxy/injectproxy/rules.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus-community/prom-label-proxy/injectproxy/silences.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus-community/prom-label-proxy/injectproxy/utils.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/alertmanager/COPYRIGHT.txtis excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/alertmanager/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/alertmanager/NOTICEis excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/alertmanager/api/v2/client/alert/alert_client.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/alertmanager/api/v2/client/alert/get_alerts_parameters.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/alertmanager/api/v2/client/alert/get_alerts_responses.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/alertmanager/api/v2/client/alert/post_alerts_parameters.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/alertmanager/api/v2/client/alert/post_alerts_responses.gois excluded by!vendor/**,!**/vendor/**
📒 Files selected for processing (3)
go.modpkg/cvo/availableupdates.gopkg/cvo/availableupdates_test.go
🧰 Additional context used
📓 Path-based instructions (1)
**
⚙️ CodeRabbit configuration file
-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.
Files:
go.modpkg/cvo/availableupdates.gopkg/cvo/availableupdates_test.go
🔇 Additional comments (3)
pkg/cvo/availableupdates.go (2)
16-17: LGTM!The new imports support the matcher-based PromQL injection approach using the official
prom-label-proxylibrary.
553-567: LGTM!The matcher-based approach using
prom-label-proxyis more robust than string manipulation. Error handling is appropriate—logging warnings and returning the original PromQL as a fallback prevents cascading failures.pkg/cvo/availableupdates_test.go (1)
762-813: No duplicate test function exists. The search found only a singleTestInjectIdIntoStringfunction definition at line 762. The test function itself is well-structured with comprehensive test cases covering scalar values, instant vectors, label handling, and invalid expressions.Likely an incorrect or invalid review comment.
| github.com/prometheus-community/prom-label-proxy v0.12.1 | ||
| github.com/prometheus/client_golang v1.23.2 | ||
| github.com/prometheus/client_model v0.6.2 | ||
| github.com/prometheus/common v0.66.1 | ||
| github.com/prometheus/prometheus v0.305.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# First, locate and examine the go.mod file
find . -name "go.mod" -type f | head -20Repository: openshift/cluster-version-operator
Length of output: 86
🏁 Script executed:
#!/bin/bash
# If go.mod exists at root, examine lines around 20-24
if [ -f "go.mod" ]; then
echo "=== go.mod content (lines 15-30) ==="
sed -n '15,30p' go.mod
echo ""
echo "=== Full module declaration ==="
head -5 go.mod
fiRepository: openshift/cluster-version-operator
Length of output: 885
🌐 Web query:
prom-label-proxy v0.12.1 security vulnerabilities CVE
💡 Result:
I couldn't find any CVE entries for prom-label-proxy v0.12.1. The project's GitHub/releases pages list the v0.12.x series but no security advisories or CVE IDs are published for that release. [1][2]
If you want, I can (a) monitor NVD/GHSA for new CVEs and alert you, or (b) run a focused dependency scan (SCA) against your image/artifacts to check for CVEs in dependencies. [1] https://github.com/prometheus-community/prom-label-proxy. [2] release listing / changelog for the project. [3] Snyk package page for related prom-label-proxy packages (no CVE for upstream prom-label-proxy v0.12.1 listed).
🌐 Web query:
prometheus client_golang v1.23.2 security vulnerabilities
💡 Result:
Short answer: There are no public CVEs that specifically affect prometheus/client_golang v1.23.2. Known serious client_golang vulnerabilities (e.g., CVE‑2022‑21698 / GO‑2022‑0322 — promhttp unbounded cardinality DoS) were fixed in much earlier releases (fixed in v1.11.1); v1.23.2 is a 2025 maintenance release with no functional/security changes listed. [1][2]
Sources:
- client_golang v1.23.2 release notes (no security/fix entries). [1]
- OSV / GO-2022-0322 (CVE-2022-21698) denial-of-service advisory affecting < v1.11.1. [2]
🌐 Web query:
prometheus v0.305.0 security vulnerabilities
💡 Result:
I found one confirmed public CVE that lists v0.305.0 as an affected Prometheus version:
- CVE‑2019‑3826 — stored DOM cross‑site scripting (XSS) in Prometheus < 2.7.1 (listed as affecting v0.305.0 by several vulnerability trackers). [NVD][1], [OpenHub][2].
I did not find any separate/new high‑severity CVEs specifically introduced in the v0.305.0 release in the sources searched. For a complete, up‑to‑date inventory for your environment I recommend checking the NVD/MITRE entries and your distro/security advisories (they may map package builds to CVEs). Relevant sources: NVD CVE‑2019‑3826 and OpenHub version->vulnerability mapping. [1][2]
Sources
- NVD — CVE‑2019‑3826 (Prometheus XSS). [NVD entry]. [3].
- OpenHub — Prometheus vulnerabilities / versions (shows v0.305.0 linked to CVE‑2019‑3826). [4].
(If you want, I can run a deeper search across vendor advisories, GitHub issues, and distro trackers and return a full CVE list and mitigation steps.)
Investigate prometheus v0.305.0 — associated with CVE-2019-3826 (XSS vulnerability).
The addition of prom-label-proxy v0.12.1 appears secure with no known vulnerabilities, and prometheus/client_golang v1.23.2 is a recent 2025 release with no active CVEs.
However, prometheus v0.305.0 is flagged for CVE-2019-3826, a stored DOM cross-site scripting vulnerability affecting Prometheus versions below 2.7.1. The version number format (v0.305.0) is also unusual for modern Prometheus releases and should be verified — confirm whether this is the intended version or if it should be updated to a more recent release like v2.54.x or later.
🤖 Prompt for AI Agents
In @go.mod around lines 20 - 24, The go.mod entry
"github.com/prometheus/prometheus v0.305.0" is suspicious (unusual versioning)
and flagged by the reviewer for CVE-2019-3826; verify whether that is the
intended module/version and replace it with a supported, non-vulnerable
Prometheus release (e.g., update the require to a modern v2.54.x or later), then
run go get github.com/prometheus/prometheus@<desired-version> and go mod tidy to
update go.sum, followed by running your dependency vulnerability scanner and
project tests to confirm the upgrade did not break compatibility.
|
@simonpasquier: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR leverages the
github.com/prometheus-community/prom-label-proxy/injectproxyGopackage to inject the
_idlabel in a reliable fashion. The previous implementation assumed the presence of the_idlabel in the original expression to work properly./cc @wking