Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STOR-1167: Add permissions needed by fast snapshots to AWS CSI driver #369

Merged
merged 1 commit into from
Jun 23, 2023
Merged

STOR-1167: Add permissions needed by fast snapshots to AWS CSI driver #369

merged 1 commit into from
Jun 23, 2023

Conversation

jsafrane
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 18, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 18, 2023 •
edited by openshift-ci bot
Loading

@jsafrane: This pull request references STOR-1167 which is a valid jira issue.

In response to this:

As mentioned in upstream fast-restore docs: https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/docs/fast-snapshot-restores.md#prerequisites

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsafrane jsafrane mentioned this pull request May 18, 2023
Merged
@openshift-ci openshift-ci bot requested review from bertinatto and gnufied May 18, 2023 12:18
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2023
@jsafrane
Copy link
Contributor Author

/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels May 18, 2023
@Phaow
Copy link
Contributor

Phaow commented May 25, 2023

Pre merge test passed with job build openshift/aws-ebs-csi-driver#222,openshift/cluster-storage-operator#369,openshift/aws-ebs-csi-driver-operator#223 succeeded
With the fix patch, the fast snapshots created successfully.

@Phaow
Copy link
Contributor

Phaow commented May 25, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label May 25, 2023
@dobsonj
Copy link
Member

dobsonj commented May 30, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD cf2524d and 2 for PR HEAD 73fa810 in total

@jsafrane
Copy link
Contributor Author

/retest-required

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 3198372 and 1 for PR HEAD 73fa810 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD a3e819e and 0 for PR HEAD 73fa810 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2023 •
edited
Loading

@jsafrane: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn 73fa810 link false /test e2e-azure-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/hold

Revision 73fa810 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 21, 2023
@jsafrane
Copy link
Contributor Author

/hold cancel
/retest-required

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9bdc393 and 2 for PR HEAD 73fa810 in total

@jsafrane
Copy link
Contributor Author

/retest-required

@openshift-merge-robot openshift-merge-robot merged commit c1cf58f into openshift:master Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto Awaiting requested review from bertinatto

@gnufied gnufied Awaiting requested review from gnufied

Assignees

@dobsonj dobsonj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jsafrane @openshift-ci-robot @Phaow @dobsonj @openshift-merge-robot