Skip to content

Conversation

@gabemontero
Copy link
Contributor

cherry pick failed ... example #380 (comment)

ultimately want to get this back to 4.7 .... see #385 (comment)

/assign @dperaza4dustbit

more tech debt I was still carrying prior to hand off

@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Sep 7, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 7, 2021

@gabemontero: This pull request references Bugzilla bug 2001974, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.z) matches configured target release for branch (4.8.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1975539 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1975539 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
  • bug has dependents

Requesting review from QA contact:
/cc @jitendar-singh

Details

In response to this:

Bug 2001974: delete hello-openshift in payload imagestream via CVO annotation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 7, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 7, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2021
@gabemontero
Copy link
Contributor Author

/hold

I want to confirm hello-openshift is still not installed in the e2e results before merging

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 7, 2021
@gabemontero
Copy link
Contributor Author

/test unit

@gabemontero
Copy link
Contributor Author

samples clean, other failed, e2e-aws-upgrade

/retest

@gabemontero
Copy link
Contributor Author

the hello openshift imagestream is still present in 4.8

that installer annotation may not be supported in 4.8 ... investigating

@gabemontero
Copy link
Contributor Author

Confirmed it has not been backported. Have inquiry to see if it will be.

Inquiring int https://bugzilla.redhat.com/show_bug.cgi?id=1976307 to see if it will be.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 7, 2021

@gabemontero: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/okd-e2e-aws-upgrade 2c0ad82 link /test okd-e2e-aws-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gabemontero
Copy link
Contributor Author

/skip

@gabemontero
Copy link
Contributor Author

per @jottofar the annotation is not getting backported

just closing this out

@gabemontero gabemontero closed this Sep 9, 2021
@gabemontero gabemontero deleted the proper-rm-hello-openshift-48 branch September 9, 2021 13:04
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2021

@gabemontero: This pull request references Bugzilla bug 2001974. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

Details

In response to this:

Bug 2001974: delete hello-openshift in payload imagestream via CVO annotation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants