Skip to content

Conversation

@perdasilva
Copy link

@perdasilva perdasilva commented Nov 5, 2024

Description

All resources listed in .status.relatedObjects of the ClusterOperator resource will get picked up by must-gather.
Previously, the openshift-cluster-olm-operator namespace (and included resources: deployments, services, etc.), and the cluster scoped OLM resource were not getting picked up by must-gather. Only the o-c and catd resources, which are dynamically added to the ClusterOperator at start-up.

This PR introduces two changes:

  • Updates the ClusterOperator manifest to include the openshift-cluster-olm-operator namespace and OLM resources in its .status.relatedObjects. This ensures that, in the event of catastrophic failure, the namespace, its resources, and the OLM resource get picked up by must-gather
  • Updates the final list of relatedObjects to include these two resources, as the update will wipe the existing values. Thus, ensuring that the same resources are present in the must-gather for failures after the CO gets updated.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2024
@perdasilva
Copy link
Author

/hold test PR

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2024
@perdasilva perdasilva force-pushed the perdasilva/olm-related-objects branch 8 times, most recently from bfb0030 to 6b7ebc8 Compare November 7, 2024 12:30
@perdasilva perdasilva changed the title [HOLD] Add OLM resource to relatedObjects Add OLM resource to relatedObjects Nov 7, 2024
@perdasilva perdasilva force-pushed the perdasilva/olm-related-objects branch from 6b7ebc8 to 66ccc3a Compare November 7, 2024 12:55
@perdasilva
Copy link
Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2024
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2024
@perdasilva perdasilva changed the title Add OLM resource to relatedObjects OPRUN-3599: Add OLM resource to relatedObjects Nov 7, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 7, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 7, 2024

@perdasilva: This pull request references OPRUN-3599 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Description

All resources listed in .status.relatedObjects of the ClusterOperator resource will get picked up by must-gather.
Previously, the openshift-cluster-olm-operator namespace (and included resources: deployments, services, etc.), and the cluster scoped OLM resource were not getting picked up by must-gather. Only the o-c and catd resources, which are dynamically added to the ClusterOperator at start-up.

This PR introduces two changes:

  • Updates the ClusterOperator manifest to include the openshift-cluster-olm-operator namespace and OLM resources in its .status.relatedObjects. This ensures that, in the event of catastrophic failure, the namespace, its resources, and the OLM resource get picked up by must-gather
  • Updates the final list of relatedObjects to include these two resources, as the update will wipe the existing values. Thus, ensuring that the same resources are present in the must-gather for failures after the CO gets updated.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@perdasilva perdasilva force-pushed the perdasilva/olm-related-objects branch from 66ccc3a to 45025e4 Compare November 7, 2024 14:44
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2024
@joelanford
Copy link
Member

/hold cancel
/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 7, 2024
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, joelanford, perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [everettraven,joelanford,perdasilva]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 7120e60 and 2 for PR HEAD 45025e4 in total

@perdasilva
Copy link
Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 8, 2024

@perdasilva: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 1df7873 into openshift:main Nov 8, 2024
5 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-olm-operator
This PR has been included in build ose-cluster-olm-operator-container-v4.18.0-202411081440.p0.g1df7873.assembly.stream.el9.
All builds following this will include this PR.

perdasilva pushed a commit to perdasilva/cluster-olm-operator that referenced this pull request Nov 8, 2024
…d-objects

OPRUN-3599: Add OLM resource to relatedObjects
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants