-
Notifications
You must be signed in to change notification settings - Fork 33
OPRUN-3599: Add OLM resource to relatedObjects #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OPRUN-3599: Add OLM resource to relatedObjects #77
Conversation
|
/hold test PR |
bfb0030 to
6b7ebc8
Compare
6b7ebc8 to
66ccc3a
Compare
|
/unhold |
joelanford
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
@perdasilva: This pull request references OPRUN-3599 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
66ccc3a to
45025e4
Compare
|
/hold cancel |
everettraven
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: everettraven, joelanford, perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@perdasilva: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-cluster-olm-operator |
…d-objects OPRUN-3599: Add OLM resource to relatedObjects Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Description
All resources listed in
.status.relatedObjectsof theClusterOperatorresource will get picked up by must-gather.Previously, the openshift-cluster-olm-operator namespace (and included resources: deployments, services, etc.), and the cluster scoped OLM resource were not getting picked up by must-gather. Only the o-c and catd resources, which are dynamically added to the ClusterOperator at start-up.
This PR introduces two changes:
ClusterOperatormanifest to include theopenshift-cluster-olm-operatornamespace and OLM resources in its .status.relatedObjects. This ensures that, in the event of catastrophic failure, the namespace, its resources, and the OLM resource get picked up by must-gather