Skip to content

OPRUN-4230: Add BoxcutterRuntime FG mapping#151

Closed
perdasilva wants to merge 2 commits intoopenshift:mainfrom
perdasilva:olmv1-boxcutter-tp
Closed

OPRUN-4230: Add BoxcutterRuntime FG mapping#151
perdasilva wants to merge 2 commits intoopenshift:mainfrom
perdasilva:olmv1-boxcutter-tp

Conversation

@perdasilva
Copy link

@perdasilva perdasilva commented Nov 13, 2025

Adds BoxcutterRuntime feature gate mapping

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 13, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 13, 2025 •
edited by openshift-ci bot
Loading

@perdasilva: This pull request references OPRUN-4230 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Adds BoxcutterRuntime feature gate mapping

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@perdasilva
Copy link
Author

perdasilva commented Nov 13, 2025

/hold depends on openshift/api#2577 to be merged and the replace directive being removed from go.mod

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2025
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2025
@perdasilva
Copy link
Author

perdasilva commented Nov 13, 2025

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 13, 2025 •
edited by openshift-ci bot
Loading

@perdasilva: This pull request references OPRUN-4230 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@perdasilva perdasilva force-pushed the olmv1-boxcutter-tp branch 2 times, most recently from 50b074f to 99ae491 Compare November 18, 2025 16:37
@anik120 anik120 mentioned this pull request Nov 18, 2025
Open
Add Boxcutter FG mapping
efc8d4d 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@perdasilva
Copy link
Author

perdasilva commented Nov 18, 2025

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2025
anik120
anik120 approved these changes Nov 18, 2025
View reviewed changes
Copy link
Contributor

@anik120 anik120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anik120, perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jianzhangbjz
Copy link
Member

jianzhangbjz commented Nov 19, 2025

/assign @Xia-Zhao-rh

@Xia-Zhao-rh
Copy link

Xia-Zhao-rh commented Nov 19, 2025

/retest

@Xia-Zhao-rh
Copy link

Xia-Zhao-rh commented Nov 19, 2025

/verified by @Xia-Zhao-rh

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 19, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 19, 2025

@Xia-Zhao-rh: This PR has been marked as verified by @Xia-Zhao-rh.

Details

In response to this:

/verified by @Xia-Zhao-rh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 19, 2025

/retest-required

Remaining retests: 0 against base HEAD 050f9d2 and 2 for PR HEAD efc8d4d in total

@tmshort
Copy link
Contributor

tmshort commented Nov 19, 2025

/test openshift-e2e-aws-techpreview

@tmshort
Copy link
Contributor

tmshort commented Nov 19, 2025

/test openshift-e2e-aws-devpreview

@openshift-ci-robot openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Nov 20, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 20, 2025

New changes are detected. LGTM label has been removed.

@perdasilva
Copy link
Author

perdasilva commented Nov 20, 2025

/hold testing to see what happens if we switch off preflight checks fg

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2025
@perdasilva perdasilva force-pushed the olmv1-boxcutter-tp branch 2 times, most recently from f9dd88a to b37305d Compare November 20, 2025 18:11
Disable preflight checks
066410e 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@tmshort
Copy link
Contributor

tmshort commented Nov 26, 2025

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 26, 2025

@perdasilva: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 50b074f link false /test okd-scos-e2e-aws-ovn
ci/prow/openshift-e2e-aws 066410e link true /test openshift-e2e-aws
ci/prow/openshift-e2e-aws-devpreview 066410e link true /test openshift-e2e-aws-devpreview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@perdasilva
Copy link
Author

perdasilva commented Nov 27, 2025

going to close this for now

@perdasilva perdasilva closed this Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LalatenduMohanty LalatenduMohanty Awaiting requested review from LalatenduMohanty

@oceanc80 oceanc80 Awaiting requested review from oceanc80

1 more reviewer

@anik120 anik120 anik120 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@anik120 anik120

@Xia-Zhao-rh Xia-Zhao-rh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@perdasilva @openshift-ci-robot @jianzhangbjz @Xia-Zhao-rh @tmshort @anik120