Skip to content

OCPBUGS-49410: extend clusterrole with permissions for OCP observability #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2025
Merged

OCPBUGS-49410: extend clusterrole with permissions for OCP observability #103

merged 1 commit into from
Feb 6, 2025

Conversation

@azych
Copy link
Contributor

@azych azych commented Feb 4, 2025 •
edited
Loading

This adds the remaining necessary clusterrole permissions that cluster-olm-operator needs to be able to grant and act on for the catalogd and operator-controller to facilitate automatic metrics collection via OCP machinery

Specific necessary permissions are:

  • create, read, list, watch servicemonitors
  • read, list, watch endpoints, pods and services
  • bind for the newly created metric monitor roles

part of OCPBUGS-49410 resolution
prerequisite for openshift/operator-framework-operator-controller#252

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 4, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 4, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@azych azych changed the title add ability to bind metrics monitor role [Draft] add ability to bind metrics monitor role Feb 4, 2025
@azych azych force-pushed the bind-metrics-monitor-role branch 2 times, most recently from 006cfee to a9de922 Compare February 4, 2025 13:55
@azych
extend clusterrole with permissions for OCP observability
1940a61 
This adds the remaining necessary clusterrole permissions
that cluster-olm-operator needs to be able to grant
and act on for the catalogd and operator-controller
to facilitate automatic metrics collection via OCP machinery

Specific necessary permissions are:
- create, read, list, watch servicemonitors
- read, list, watch endpoints, pods and services
- bind for the newly created metric monitors roles
@azych azych force-pushed the bind-metrics-monitor-role branch from a9de922 to 1940a61 Compare February 4, 2025 17:39
@azych azych changed the title [Draft] add ability to bind metrics monitor role [OCPBUGS-49410] extend clusterrole with permissions for OCP observability Feb 5, 2025
@azych azych marked this pull request as ready for review February 5, 2025 08:14
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 5, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 5, 2025

@azych: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@azych azych mentioned this pull request Feb 6, 2025
Merged
tmshort
tmshort reviewed Feb 6, 2025
View reviewed changes
manifests/0000_51_olm_02_operator_clusterrole.yaml
Comment on lines +76 to +77
# necessary for OCP monitoring
# together with endpoints, services, pods
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment probably unnecessary.

@tmshort
Copy link
Contributor

tmshort commented Feb 6, 2025

/retitle OCPBUGS-49410: extend clusterrole with permissions for OCP observability

@openshift-ci openshift-ci bot changed the title [OCPBUGS-49410] extend clusterrole with permissions for OCP observability OCPBUGS-49410: extend clusterrole with permissions for OCP observability Feb 6, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Feb 6, 2025
@openshift-ci-robot
Copy link

@azych: This pull request references Jira Issue OCPBUGS-49410, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @Xia-Zhao-rh

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This adds the remaining necessary clusterrole permissions that cluster-olm-operator needs to be able to grant and act on for the catalogd and operator-controller to facilitate automatic metrics collection via OCP machinery

Specific necessary permissions are:

  • create, read, list, watch servicemonitors
  • read, list, watch endpoints, pods and services
  • bind for the newly created metric monitor roles

part of OCPBUGS-49410 resolution
prerequisite for openshift/operator-framework-operator-controller#252

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from Xia-Zhao-rh February 6, 2025 15:07
@tmshort
Copy link
Contributor

tmshort commented Feb 6, 2025

/approve
/lgtm
/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Feb 6, 2025
tmshort
tmshort approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: azych, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 382a0d3 into openshift:main Feb 6, 2025
7 checks passed
@openshift-ci-robot
Copy link

@azych: Jira Issue OCPBUGS-49410: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-49410 has not been moved to the MODIFIED state.

In response to this:

This adds the remaining necessary clusterrole permissions that cluster-olm-operator needs to be able to grant and act on for the catalogd and operator-controller to facilitate automatic metrics collection via OCP machinery

Specific necessary permissions are:

  • create, read, list, watch servicemonitors
  • read, list, watch endpoints, pods and services
  • bind for the newly created metric monitor roles

part of OCPBUGS-49410 resolution
prerequisite for openshift/operator-framework-operator-controller#252

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-olm-operator
This PR has been included in build ose-cluster-olm-operator-container-v4.19.0-202502061739.p0.g382a0d3.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinrizza kevinrizza Awaiting requested review from kevinrizza

@LalatenduMohanty LalatenduMohanty Awaiting requested review from LalatenduMohanty

@Xia-Zhao-rh Xia-Zhao-rh Awaiting requested review from Xia-Zhao-rh

1 more reviewer

@tmshort tmshort tmshort approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tmshort tmshort

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@azych @tmshort @openshift-ci-robot @openshift-bot