Skip to content

doc: fix description of the PERFORMANCE_PROFILE_INPUT_FILES env var #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 2, 2022
Merged

doc: fix description of the PERFORMANCE_PROFILE_INPUT_FILES env var #399

merged 2 commits into from
Aug 2, 2022

Conversation

jlojosnegros
Copy link
Contributor

Environment variable PERFORMANCE_PROFILE_INPUT_FILES used in render mode
should be a comma separated list of PerformanceProfile manifests not a
folder.

@openshift-ci openshift-ci bot requested review from swatisehgal and yanirq July 22, 2022 10:31
marioferh
marioferh reviewed Jul 26, 2022
View reviewed changes
Copy link
Contributor

@marioferh marioferh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2022
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 26, 2022
@jlojosnegros
Minor correction in Performance Addon doc
33a40cd 
Environment variable PERFORMANCE_PROFILE_INPUT_FILES used in render mode
should be a comma separated list of PerformanceProfile manifests not a
folder.
@jlojosnegros
Solve minor layout issues in Markdown file
a347d6a
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 26, 2022
@jlojosnegros
Copy link
Contributor Author

just rebasing

@jlojosnegros
Copy link
Contributor Author

jlojosnegros commented Jul 27, 2022 •
edited
Loading

/retest-required

1 similar comment
@jlojosnegros
Copy link
Contributor Author

/retest-required

marioferh
marioferh reviewed Aug 1, 2022
View reviewed changes
Copy link
Contributor

@marioferh marioferh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2022
@ffromani
Copy link
Contributor

ffromani commented Aug 2, 2022

/retitle doc: fix description of the PERFORMANCE_PROFILE_INPUT_FILES env var

@openshift-ci openshift-ci bot changed the title Minor correction in Performance Addon document. doc: fix description of the PERFORMANCE_PROFILE_INPUT_FILES env var Aug 2, 2022
@ffromani
Copy link
Contributor

ffromani commented Aug 2, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fromanirh, jlojosnegros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 2b8674b and 8 for PR HEAD a347d6a in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 285eec9 and 7 for PR HEAD a347d6a in total

@openshift-merge-robot openshift-merge-robot merged commit c49df5a into openshift:master Aug 2, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 2, 2022

@jlojosnegros: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

IlyaTyomkin pushed a commit to IlyaTyomkin/cluster-node-tuning-operator that referenced this pull request May 23, 2023
@jlojosnegros @IlyaTyomkin
doc: fix description of the PERFORMANCE_PROFILE_INPUT_FILES env var (…
6a54026 
…openshift#399)

* Minor correction in Performance Addon doc

Environment variable PERFORMANCE_PROFILE_INPUT_FILES used in render mode
should be a comma separated list of PerformanceProfile manifests not a
folder.

* Solve minor layout issues in Markdown file
IlyaTyomkin pushed a commit to IlyaTyomkin/cluster-node-tuning-operator that referenced this pull request Jun 13, 2023
@jlojosnegros @IlyaTyomkin
doc: fix description of the PERFORMANCE_PROFILE_INPUT_FILES env var (…
1b3befa 
…openshift#399)

* Minor correction in Performance Addon doc

Environment variable PERFORMANCE_PROFILE_INPUT_FILES used in render mode
should be a comma separated list of PerformanceProfile manifests not a
folder.

* Solve minor layout issues in Markdown file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioferh marioferh marioferh left review comments

@swatisehgal swatisehgal Awaiting requested review from swatisehgal

@yanirq yanirq Awaiting requested review from yanirq

@MarSik MarSik Awaiting requested review from MarSik

Assignees

@marioferh marioferh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jlojosnegros @ffromani @openshift-ci-robot @MarSik @marioferh @openshift-merge-robot