WiP: PSAP-1178: Add NetworkPolicy k8s resources #1323
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@jmencak: This pull request references PSAP-1178 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmencak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
test/e2e/basic/modules.go
Outdated
| @@ -59,8 +59,7 @@ var _ = ginkgo.Describe("[basic][modules] Node Tuning Operator load kernel modul | |||
| gomega.Expect(err).NotTo(gomega.HaveOccurred()) | |||
|
|
|||
| ginkgo.By(fmt.Sprintf("trying to remove the %s module if loaded", moduleName)) | |||
| _, err = util.ExecCmdInPod(pod, "rmmod", moduleName) | |||
| gomega.Expect(err).To(gomega.HaveOccurred()) | |||
| _, _ = util.ExecCmdInPod(pod, "rmmod", moduleName) | |||
There was a problem hiding this comment.
Why do we need this change?
There was a problem hiding this comment.
Good catch, I'll remove this. This is fixed by #1322
|
@jmencak Thanks for your work Jiri. |
This change adds a default deny NetworkPolicy for ingress and egress in the openshift-cluster-node-tuning-operator namespace. The following flows are allowed by NetworkPolicies: - access to the API server - access to NTO Metrics server - access to NTO Webhook server Resolves: PSAP-1178
jmencak
force-pushed
the
4.20-network_policy
branch
from
343a3f0 to
1b61c36
Compare
|
New changes are detected. LGTM label has been removed. |
|
@jmencak: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This change adds a default deny NetworkPolicy for ingress and egress in the openshift-cluster-node-tuning-operator namespace. The following flows are allowed by NetworkPolicies:
Resolves: PSAP-1178