OCPBUGS-63743: Rename transit subnet flags #2828

kyrtapz · 2025-11-03T13:42:00Z

Rename the flags according to the changes introduced in: ovn-kubernetes/ovn-kubernetes#5561

Rename the flags according to the changes introduced in: ovn-kubernetes/ovn-kubernetes#5561 Signed-off-by: Patryk Diak <pdiak@redhat.com>

openshift-ci-robot · 2025-11-03T13:42:08Z

@kyrtapz: This pull request references Jira Issue OCPBUGS-63743, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.0) matches configured target version for branch (4.21.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Rename the flags according to the changes introduced in: ovn-kubernetes/ovn-kubernetes#5561

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ricky-rav

/LGTM

openshift-ci · 2025-11-03T13:51:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyrtapz, ricky-rav

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [kyrtapz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kyrtapz · 2025-11-04T07:33:54Z

/retest-required

kyrtapz · 2025-11-04T12:40:36Z

/verified by @kyrtapz

openshift-ci-robot · 2025-11-04T12:40:49Z

@kyrtapz: This PR has been marked as verified by @kyrtapz.

In response to this:

/verified by @kyrtapz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2025-11-04T12:41:22Z

Walkthrough

Command-line flag names for OVN Kubernetes transit subnet configuration are updated by removing the word "switch" from flag names across multiple YAML configuration files, affecting both IPv4 and IPv6 options. Some files contain only whitespace adjustments.

Changes

Cohort / File(s)	Summary
Transit subnet flag renaming `bindata/network/ovn-kubernetes/common/008-script-lib.yaml`, `bindata/network/ovn-kubernetes/managed/ovnkube-control-plane.yaml`	Updated command-line options by removing "switch" from transit subnet flag names: `--cluster-manager-v4-transit-switch-subnet` → `--cluster-manager-v4-transit-subnet` and `--cluster-manager-v6-transit-switch-subnet` → `--cluster-manager-v6-transit-subnet`
Whitespace adjustments `bindata/network/ovn-kubernetes/self-hosted/ovnkube-control-plane.yaml`, `bindata/network/ovn-kubernetes/self-hosted/ovnkube-node.yaml`	Whitespace-only changes with no functional or semantic impact on transit switch subnet options

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Verify that the flag name changes (--cluster-manager-v{4,6}-transit-subnet) are consistent across all configuration files and match expected upstream or downstream integrations
Confirm that template variable names (V4TransitSwitchSubnet, V6TransitSwitchSubnet) remain aligned with the updated flag names and no additional updates are required elsewhere in the codebase

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between aec3a20 and dc7acee.

📒 Files selected for processing (4)

bindata/network/ovn-kubernetes/common/008-script-lib.yaml (1 hunks)
bindata/network/ovn-kubernetes/managed/ovnkube-control-plane.yaml (1 hunks)
bindata/network/ovn-kubernetes/self-hosted/ovnkube-control-plane.yaml (1 hunks)
bindata/network/ovn-kubernetes/self-hosted/ovnkube-node.yaml (1 hunks)

🔇 Additional comments (4)

bindata/network/ovn-kubernetes/self-hosted/ovnkube-node.yaml (1)

521-528: Flag names correctly updated for consistency with OVN Kubernetes upstream.

The transit subnet flags have been consistently renamed across the configuration by removing "switch" from the flag names. The variable names retain "switch" for clarity but are properly assigned the updated flag values. This allows hybrid-overlay-node invocation to use the correct upstream-aligned flags.

bindata/network/ovn-kubernetes/self-hosted/ovnkube-control-plane.yaml (1)

118-125: Consistent flag renaming for cluster-manager control plane.

The transit subnet flags are updated identically to other manifests, ensuring unified flag naming across the control plane deployment configurations. Variables are correctly integrated into the ovnkube cluster-manager command invocation.

bindata/network/ovn-kubernetes/common/008-script-lib.yaml (1)

702-709: Script library correctly updated to use renamed flags.

The common start-ovnkube-node() function in the shared script library is updated with the correct flag names. This centralized update ensures all deployments that use this library apply the consistent transit subnet flag naming.

bindata/network/ovn-kubernetes/managed/ovnkube-control-plane.yaml (1)

167-174: Managed cluster control plane flags correctly updated.

The HyperShift managed deployment variant is updated with the same flag naming convention. Consistent application across all deployment modes (self-hosted, common library, managed) validates the thoroughness of this refactoring.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci-robot · 2025-11-04T12:49:35Z

/retest-required

Remaining retests: 0 against base HEAD aec3a20 and 2 for PR HEAD dc7acee in total

kyrtapz · 2025-11-04T16:58:35Z

/retest-required

kyrtapz · 2025-11-05T09:26:47Z

The failing metal jobs do not excersise the changes introduced, the failures are unrelated.
/override ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw

kyrtapz · 2025-11-05T09:27:03Z

/override ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec

openshift-ci · 2025-11-05T09:27:05Z

@kyrtapz: Overrode contexts on behalf of kyrtapz: ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw

In response to this:

The failing metal jobs do not excersise the changes introduced, the failures are unrelated.
/override ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2025-11-05T09:27:08Z

@kyrtapz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-upgrade	`dc7acee`	link	false	`/test 4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-upgrade`
ci/prow/4.21-upgrade-from-stable-4.20-e2e-aws-ovn-upgrade	`dc7acee`	link	false	`/test 4.21-upgrade-from-stable-4.20-e2e-aws-ovn-upgrade`
ci/prow/okd-scos-e2e-aws-ovn	`dc7acee`	link	false	`/test okd-scos-e2e-aws-ovn`
ci/prow/4.21-upgrade-from-stable-4.20-e2e-azure-ovn-upgrade	`dc7acee`	link	false	`/test 4.21-upgrade-from-stable-4.20-e2e-azure-ovn-upgrade`
ci/prow/security	`dc7acee`	link	false	`/test security`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci · 2025-11-05T09:27:19Z

@kyrtapz: Overrode contexts on behalf of kyrtapz: ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot · 2025-11-05T09:30:54Z

@kyrtapz: Jira Issue Verification Checks: Jira Issue OCPBUGS-63743
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-63743 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

Rename the flags according to the changes introduced in: ovn-kubernetes/ovn-kubernetes#5561

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-robot · 2025-11-06T07:16:09Z

Fix included in accepted release 4.21.0-0.nightly-2025-11-05-234508

Rename transit subnet flags

dc7acee

Rename the flags according to the changes introduced in: ovn-kubernetes/ovn-kubernetes#5561 Signed-off-by: Patryk Diak <pdiak@redhat.com>

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Nov 3, 2025

openshift-ci bot requested review from anuragthehatter, jcaamano and tssurya November 3, 2025 13:42

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2025

ricky-rav approved these changes Nov 3, 2025

View reviewed changes

openshift-ci bot assigned ricky-rav Nov 3, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2025

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 4, 2025

openshift-merge-bot bot merged commit 9274675 into openshift:master Nov 5, 2025
24 of 29 checks passed

OCPBUGS-63743: Rename transit subnet flags #2828

OCPBUGS-63743: Rename transit subnet flags #2828

Uh oh!

Conversation

kyrtapz commented Nov 3, 2025

Uh oh!

openshift-ci-robot commented Nov 3, 2025

Uh oh!

ricky-rav left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Nov 3, 2025

Uh oh!

kyrtapz commented Nov 4, 2025

Uh oh!

kyrtapz commented Nov 4, 2025

Uh oh!

openshift-ci-robot commented Nov 4, 2025

Uh oh!

coderabbitai bot commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

openshift-ci-robot commented Nov 4, 2025

Uh oh!

kyrtapz commented Nov 4, 2025

Uh oh!

kyrtapz commented Nov 5, 2025

Uh oh!

kyrtapz commented Nov 5, 2025

Uh oh!

openshift-ci bot commented Nov 5, 2025

Uh oh!

openshift-ci bot commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Nov 5, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Nov 5, 2025

Uh oh!

openshift-merge-robot commented Nov 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coderabbitai bot commented Nov 4, 2025 •

edited

Loading

openshift-ci bot commented Nov 5, 2025 •

edited

Loading