Skip to content

Conversation

@jluhrsen
Copy link
Contributor

the HACKING.md doc no longer exists

the HACKING.md doc no longer exists

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 24, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jluhrsen
Copy link
Contributor Author

@kyrtapz , wish we didn't have to run CI for this one line doc change, but can you PTAL?

@jluhrsen jluhrsen marked this pull request as ready for review October 24, 2025 20:10
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 24, 2025
@openshift-ci openshift-ci bot requested review from jcaamano and kyrtapz October 24, 2025 20:11
@jluhrsen
Copy link
Contributor Author

/retest

@jluhrsen
Copy link
Contributor Author

jluhrsen commented Nov 3, 2025

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 4, 2025

@jluhrsen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.21-upgrade-from-stable-4.20-e2e-azure-ovn-upgrade c9875f5 link false /test 4.21-upgrade-from-stable-4.20-e2e-azure-ovn-upgrade
ci/prow/4.21-upgrade-from-stable-4.20-e2e-aws-ovn-upgrade c9875f5 link false /test 4.21-upgrade-from-stable-4.20-e2e-aws-ovn-upgrade
ci/prow/security c9875f5 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kyrtapz
Copy link
Contributor

kyrtapz commented Nov 5, 2025

/lgtm
/override ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec
/override

@kyrtapz
Copy link
Contributor

kyrtapz commented Nov 5, 2025

/override ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw
/override ci/prow/e2e-metal-ipi-ovn-dualstack-bgp

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2025
@kyrtapz
Copy link
Contributor

kyrtapz commented Nov 5, 2025

/retitle NO-JIRA: add wiki link for using ./hack/run-locally.sh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jluhrsen, kyrtapz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot changed the title add wiki link for using ./hack/run-locally.sh NO-JIRA: add wiki link for using ./hack/run-locally.sh Nov 5, 2025
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 5, 2025
@openshift-ci-robot
Copy link
Contributor

@jluhrsen: This pull request explicitly references no jira issue.

In response to this:

the HACKING.md doc no longer exists

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 5, 2025

@kyrtapz: Overrode contexts on behalf of kyrtapz: ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec

In response to this:

/lgtm
/override ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec
/override

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coderabbitai
Copy link

coderabbitai bot commented Nov 5, 2025

Walkthrough

Updated the header comment in hack/run-locally.sh to replace a reference to HACKING.md with a direct wiki URL for local cluster network operator plugin development documentation. No functional code changes made.

Changes

Cohort / File(s) Summary
Documentation/Comments
hack/run-locally.sh
Updated header comment to replace HACKING.md reference with direct wiki URL for local cluster network operator setup

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between c563eb4 and c9875f5.

📒 Files selected for processing (1)
  • hack/run-locally.sh (1 hunks)
🔇 Additional comments (1)
hack/run-locally.sh (1)

5-5: Replace dead HACKING.md reference with live wiki documentation link.

This straightforward improvement replaces the outdated HACKING.md reference with a direct wiki URL. The wiki page and anchor have been verified as accessible and correct.


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 5, 2025

@kyrtapz: Overrode contexts on behalf of kyrtapz: ci/prow/e2e-metal-ipi-ovn-dualstack-bgp, ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw
/override ci/prow/e2e-metal-ipi-ovn-dualstack-bgp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kyrtapz
Copy link
Contributor

kyrtapz commented Nov 5, 2025

/verified by @kyrtapz

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 5, 2025
@openshift-ci-robot
Copy link
Contributor

@kyrtapz: This PR has been marked as verified by @kyrtapz.

In response to this:

/verified by @kyrtapz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kyrtapz
Copy link
Contributor

kyrtapz commented Nov 5, 2025

This is a doc change

/override 4.21-upgrade-from-stable-4.20-images
/override e2e-aws-ovn-hypershift-conformance
/override e2e-aws-ovn-serial-1of2
/override e2e-aws-ovn-serial-2of2
/override e2e-aws-ovn-upgrade
/override e2e-aws-ovn-upgrade-ipsec
/override e2e-aws-ovn-windows
/override e2e-azure-ovn-upgrade
/override e2e-gcp-ovn
/override e2e-gcp-ovn-upgrade
/override e2e-metal-ipi-ovn-ipv6
/override e2e-ovn-ipsec-step-registry
/override hypershift-e2e-aks
/override images
/override okd-scos-images

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 5, 2025

@kyrtapz: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • 4.21-upgrade-from-stable-4.20-images
  • e2e-aws-ovn-hypershift-conformance
  • e2e-aws-ovn-serial-1of2
  • e2e-aws-ovn-serial-2of2
  • e2e-aws-ovn-upgrade
  • e2e-aws-ovn-upgrade-ipsec
  • e2e-aws-ovn-windows
  • e2e-azure-ovn-upgrade
  • e2e-gcp-ovn
  • e2e-gcp-ovn-upgrade
  • e2e-metal-ipi-ovn-ipv6
  • e2e-ovn-ipsec-step-registry
  • hypershift-e2e-aks
  • images
  • okd-scos-images

Only the following failed contexts/checkruns were expected:

  • CodeRabbit
  • ci/prow/4.21-upgrade-from-stable-4.20-e2e-aws-ovn-upgrade
  • ci/prow/4.21-upgrade-from-stable-4.20-e2e-azure-ovn-upgrade
  • ci/prow/4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-upgrade
  • ci/prow/4.21-upgrade-from-stable-4.20-images
  • ci/prow/e2e-aws-ovn-hypershift-conformance
  • ci/prow/e2e-aws-ovn-serial-1of2
  • ci/prow/e2e-aws-ovn-serial-2of2
  • ci/prow/e2e-aws-ovn-upgrade
  • ci/prow/e2e-aws-ovn-upgrade-ipsec
  • ci/prow/e2e-aws-ovn-windows
  • ci/prow/e2e-azure-ovn-upgrade
  • ci/prow/e2e-gcp-ovn
  • ci/prow/e2e-gcp-ovn-upgrade
  • ci/prow/e2e-metal-ipi-ovn-dualstack-bgp
  • ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw
  • ci/prow/e2e-metal-ipi-ovn-ipv6
  • ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec
  • ci/prow/e2e-ovn-ipsec-step-registry
  • ci/prow/hypershift-e2e-aks
  • ci/prow/images
  • ci/prow/lint
  • ci/prow/okd-scos-e2e-aws-ovn
  • ci/prow/okd-scos-images
  • ci/prow/security
  • ci/prow/unit
  • ci/prow/verify
  • ci/prow/verify-deps
  • pull-ci-openshift-cluster-network-operator-master-4.21-upgrade-from-stable-4.20-e2e-aws-ovn-upgrade
  • pull-ci-openshift-cluster-network-operator-master-4.21-upgrade-from-stable-4.20-e2e-azure-ovn-upgrade
  • pull-ci-openshift-cluster-network-operator-master-4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-upgrade
  • pull-ci-openshift-cluster-network-operator-master-4.21-upgrade-from-stable-4.20-images
  • pull-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-hypershift-conformance
  • pull-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-serial-1of2
  • pull-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-serial-2of2
  • pull-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-upgrade
  • pull-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-upgrade-ipsec
  • pull-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-windows
  • pull-ci-openshift-cluster-network-operator-master-e2e-azure-ovn-upgrade
  • pull-ci-openshift-cluster-network-operator-master-e2e-gcp-ovn
  • pull-ci-openshift-cluster-network-operator-master-e2e-gcp-ovn-upgrade
  • pull-ci-openshift-cluster-network-operator-master-e2e-metal-ipi-ovn-dualstack-bgp
  • pull-ci-openshift-cluster-network-operator-master-e2e-metal-ipi-ovn-dualstack-bgp-local-gw
  • pull-ci-openshift-cluster-network-operator-master-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-cluster-network-operator-master-e2e-metal-ipi-ovn-ipv6-ipsec
  • pull-ci-openshift-cluster-network-operator-master-e2e-ovn-ipsec-step-registry
  • pull-ci-openshift-cluster-network-operator-master-hypershift-e2e-aks
  • pull-ci-openshift-cluster-network-operator-master-images
  • pull-ci-openshift-cluster-network-operator-master-lint
  • pull-ci-openshift-cluster-network-operator-master-okd-scos-e2e-aws-ovn
  • pull-ci-openshift-cluster-network-operator-master-okd-scos-images
  • pull-ci-openshift-cluster-network-operator-master-security
  • pull-ci-openshift-cluster-network-operator-master-unit
  • pull-ci-openshift-cluster-network-operator-master-verify
  • pull-ci-openshift-cluster-network-operator-master-verify-deps
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

This is a doc change

/override 4.21-upgrade-from-stable-4.20-images
/override e2e-aws-ovn-hypershift-conformance
/override e2e-aws-ovn-serial-1of2
/override e2e-aws-ovn-serial-2of2
/override e2e-aws-ovn-upgrade
/override e2e-aws-ovn-upgrade-ipsec
/override e2e-aws-ovn-windows
/override e2e-azure-ovn-upgrade
/override e2e-gcp-ovn
/override e2e-gcp-ovn-upgrade
/override e2e-metal-ipi-ovn-ipv6
/override e2e-ovn-ipsec-step-registry
/override hypershift-e2e-aks
/override images
/override okd-scos-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kyrtapz
Copy link
Contributor

kyrtapz commented Nov 5, 2025

/override ci/prow/4.21-upgrade-from-stable-4.20-images
/override ci/prow/e2e-aws-ovn-hypershift-conformance
/override ci/prow/e2e-aws-ovn-serial-1of2
/override ci/prow/e2e-aws-ovn-serial-2of2
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-aws-ovn-upgrade-ipsec
/override ci/prow/e2e-aws-ovn-windows
/override ci/prow/e2e-azure-ovn-upgrade
/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-gcp-ovn-upgrade
/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-ovn-ipsec-step-registry
/override ci/prow/hypershift-e2e-aks
/override ci/prow/images
/override ci/prow/okd-scos-images

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 5, 2025

@kyrtapz: Overrode contexts on behalf of kyrtapz: ci/prow/4.21-upgrade-from-stable-4.20-images, ci/prow/e2e-aws-ovn-hypershift-conformance, ci/prow/e2e-aws-ovn-serial-1of2, ci/prow/e2e-aws-ovn-serial-2of2, ci/prow/e2e-aws-ovn-upgrade, ci/prow/e2e-aws-ovn-upgrade-ipsec, ci/prow/e2e-aws-ovn-windows, ci/prow/e2e-azure-ovn-upgrade, ci/prow/e2e-gcp-ovn, ci/prow/e2e-gcp-ovn-upgrade, ci/prow/e2e-metal-ipi-ovn-ipv6, ci/prow/e2e-ovn-ipsec-step-registry, ci/prow/hypershift-e2e-aks, ci/prow/images, ci/prow/okd-scos-images

In response to this:

/override ci/prow/4.21-upgrade-from-stable-4.20-images
/override ci/prow/e2e-aws-ovn-hypershift-conformance
/override ci/prow/e2e-aws-ovn-serial-1of2
/override ci/prow/e2e-aws-ovn-serial-2of2
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-aws-ovn-upgrade-ipsec
/override ci/prow/e2e-aws-ovn-windows
/override ci/prow/e2e-azure-ovn-upgrade
/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-gcp-ovn-upgrade
/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-ovn-ipsec-step-registry
/override ci/prow/hypershift-e2e-aks
/override ci/prow/images
/override ci/prow/okd-scos-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 05d6f46 into openshift:master Nov 5, 2025
26 of 29 checks passed
zhaozhanqi pushed a commit to zhaozhanqi/cluster-network-operator that referenced this pull request Nov 6, 2025
NO-JIRA: add wiki link for using ./hack/run-locally.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants