-
Notifications
You must be signed in to change notification settings - Fork 167
LOG-8007: Make AzureMonitor LogType a required, non-empty field #3149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@vparfonov: This pull request references LOG-8007 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.8.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test unit |
|
/assign @jcantrill |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcantrill, vparfonov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@vparfonov: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
The
LogTypefield inAzureMonitorOutput specification was previously incorrectly allowed an empty string ("") as a valid value. This leads to failing Vector collector with:2025-10-24T08:42:56.862842Z ERROR vector::topology::builder: Configuration error. error=Sink "output_abc_azure": invalid log_type "": log type can only contain letters, numbers, and underscore (_), and may not exceed 100 charactersThis PR makes the field mandatory and non-empty by:
+kubebuilder:validation:Requiredto ensure the key is present.+kubebuilder:validation:MinLength:=1to reject empty values.omitemptyfrom the JSON tag to prevent controller reconciliation errors./cc @Clee2691 @cahartma
/assign @jcantrill
Links