Skip to content

Conversation

@vparfonov
Copy link
Contributor

Description

The LogType field in AzureMonitor Output specification was previously incorrectly allowed an empty string ("") as a valid value. This leads to failing Vector collector with:
2025-10-24T08:42:56.862842Z ERROR vector::topology::builder: Configuration error. error=Sink "output_abc_azure": invalid log_type "": log type can only contain letters, numbers, and underscore (_), and may not exceed 100 characters

This PR makes the field mandatory and non-empty by:

  1. Adding +kubebuilder:validation:Required to ensure the key is present.
  2. Adding +kubebuilder:validation:MinLength:=1 to reject empty values.
  3. Removing omitempty from the JSON tag to prevent controller reconciliation errors.

/cc @Clee2691 @cahartma
/assign @jcantrill

Links

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 5, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 5, 2025

@vparfonov: This pull request references LOG-8007 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.8.0" version, but no target version was set.

In response to this:

Description

The LogType field in AzureMonitor Output specification was previously incorrectly allowed an empty string ("") as a valid value. This leads to failing Vector collector with:
2025-10-24T08:42:56.862842Z ERROR vector::topology::builder: Configuration error. error=Sink "output_abc_azure": invalid log_type "": log type can only contain letters, numbers, and underscore (_), and may not exceed 100 characters

This PR makes the field mandatory and non-empty by:

  1. Adding +kubebuilder:validation:Required to ensure the key is present.
  2. Adding +kubebuilder:validation:MinLength:=1 to reject empty values.
  3. Removing omitempty from the JSON tag to prevent controller reconciliation errors.

/cc @Clee2691 @cahartma
/assign @jcantrill

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from alanconway and cahartma November 5, 2025 14:44
@vparfonov
Copy link
Contributor Author

/test unit

@vparfonov
Copy link
Contributor Author

/assign @jcantrill

@jcantrill
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, vparfonov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2025

@vparfonov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. release/6.4

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants