Bug 1916706: go.mod: Bump go.uber.org/zap to v1.16.0

[sgreene570]

This PR attempts to resolve https://bugzilla.redhat.com/show_bug.cgi?id=1916706 by updating the zap logging dependency to v1.16.0, which includes uber-go/zap#854.

[openshift-ci-robot]

@sgreene570: This pull request references Bugzilla bug 1916865, which is invalid:

• expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1916865: go.mod: Bump go.uber.org/zap to v1.16.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@sgreene570: This pull request references Bugzilla bug 1916865, which is invalid:

• expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1916865: go.mod: Bump go.uber.org/zap to v1.16.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sgreene570

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sgreene570]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@sgreene570: This pull request references Bugzilla bug 1916706, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1916706: go.mod: Bump go.uber.org/zap to v1.16.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@sgreene570: This pull request references Bugzilla bug 1916706, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1916706: go.mod: Bump go.uber.org/zap to v1.16.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@sgreene570: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws	55559a9	link	/test e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[Miciah]

encodeStringer already had logic to recover panics. It looks like uber-go/zap#854 only changes what the recovery logic prints. Why didn't the recovery logic prevent the panic before, and how does this change prevent the panic?

[sgreene570]

encodeStringer already had logic to recover panics. It looks like uber-go/zap#854 only changes what the recovery logic prints. Why didn't the recovery logic prevent the panic before, and how does this change prevent the panic?

I don't think this change would prevent the panic, after further investigating. /close for now (@frobware feel free to /reopen if you disagree).

[sgreene570]

/close

[openshift-ci-robot]

@sgreene570: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@sgreene570: This pull request references Bugzilla bug 1916706. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

Bug 1916706: go.mod: Bump go.uber.org/zap to v1.16.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.