WIP - TEST ONLY - refactor(gatewayapi): replace OLM-based Istio install with Sail Library#1351
Closed
aslakknutsen wants to merge 6 commits intoopenshift:masterfrom
Closed
WIP - TEST ONLY - refactor(gatewayapi): replace OLM-based Istio install with Sail Library#1351aslakknutsen wants to merge 6 commits intoopenshift:masterfrom
aslakknutsen wants to merge 6 commits intoopenshift:masterfrom
Conversation
Contributor
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Member
|
@aslakknutsen please take a look into #1347 |
Contributor
Author
|
@rikatz Yeah, I'm aware. This is a slightly different approach. Just playing for now. :) |
openshift-merge-robot
added
the
needs-rebase
Replace the OLM (Operator Lifecycle Manager) based installation of Istio/OSSM with the Sail Operator library, which uses Helm directly. This simplifies the Gateway API installation flow by eliminating the need for Subscription/InstallPlan management and Istio CR lifecycle. Key changes: - Use install.NewInstaller() with PresetGatewayAPI to deploy Istio - Pass GatewayClass as ownerReference for Helm release garbage collection - Remove OLM Subscription, InstallPlan, and Istio CR watches/creation - Remove Marketplace and OLM capability gating from gatewayapi controller - Remove OLM-related CLI flags and config fields - Remove sailv1 scheme registration (no longer creating Istio CRs) - Remove Istio CRD existence check from status controller The Sail Library embeds Istio Helm charts and provides a one-shot installer API, making the installation idempotent and self-contained without requiring external operator dependencies. BREAKING CHANGE: CLI flags --gateway-api-operator-catalog, --gateway-api-operator-channel, and --gateway-api-operator-version have been removed
The --gateway-api-operator-catalog, --gateway-api-operator-channel, and --gateway-api-operator-version flags were removed from start.go but the deployment manifests still passed them. This caused the ingress operator to fail at startup with unknown flag errors, preventing cluster initialization. Removes the obsolete flags and corresponding environment variables from both 02-deployment.yaml and the generated 02-deployment-ibm-cloud-managed.yaml.
aslakknutsen
force-pushed
the
sail_library
branch
from
8eb9d51 to
4219dfc
Compare
openshift-merge-robot
removed
the
needs-rebase
Update Sail Library to latest version which adds support for custom revision names. Configure the revision to "openshift-gateway" to match the expected istiod deployment name (istiod-openshift-gateway) used in e2e tests and maintain consistency with the previous Istio CR naming.
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
11 tasks
Contributor
Author
|
Replaced by #1354 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JUST A TEST. PR TO LAUNCH VIA CLUSTERBOT
Replace the OLM (Operator Lifecycle Manager) based installation of Istio/OSSM with the Sail Operator library, which uses Helm directly. This simplifies the Gateway API installation flow by eliminating the need for Subscription/InstallPlan management and Istio CR lifecycle.
Key changes:
The Sail Library embeds Istio Helm charts and provides a one-shot installer API, making the installation idempotent and self-contained without requiring external operator dependencies.
BREAKING CHANGE: CLI flags --gateway-api-operator-catalog, --gateway-api-operator-channel, and --gateway-api-operator-version have been removed