[release-4.12] OCPBUGS-2979: automatic replacement of an unhealthy member machine by openshift-cherrypick-robot · Pull Request #960 · openshift/cluster-etcd-operator

openshift-cherrypick-robot · 2022-10-31T12:06:52Z

This is an automated cherry-pick of #947

/assign Elbehery

Elbehery · 2022-10-31T12:08:09Z

/label tide/merge-method-squash

Elbehery · 2022-10-31T12:08:25Z

/lgtm

Elbehery · 2022-10-31T12:09:28Z

/assign @tjungblu
/assign @dusk125
/assign @geliu2016

tjungblu · 2022-10-31T12:10:40Z

/lgtm

tjungblu · 2022-10-31T12:11:09Z

I think you might need to create a bug for it though, not sure Tide already is configured properly after the 4.13 branchoff.

Elbehery · 2022-10-31T12:12:18Z

ok it did not complain yet .. ok will create one now 👍🏽

Elbehery · 2022-10-31T12:21:50Z

/retitle [release-4.12] OCPBUGS-2979: automatic replacement of an unhealthy member machine

openshift-ci · 2022-10-31T12:21:55Z

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.12] OCPBUGS-2979: automatic replacement of an unhealthy member machine

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2022-10-31T12:21:56Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-2979, which is invalid:

expected the bug to target the "4.12.0" version, but it targets "4.12" instead
expected Jira Issue OCPBUGS-2979 to depend on a bug targeting a version in 4.13.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #947

/assign Elbehery

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Elbehery · 2022-10-31T12:22:12Z

I think you might need to create a bug for it though, not sure Tide already is configured properly after the 4.13 branchoff.

done 👍🏽

Elbehery · 2022-10-31T12:22:42Z

/jira refresh

openshift-ci-robot · 2022-10-31T12:22:45Z

@Elbehery: This pull request references Jira Issue OCPBUGS-2979, which is invalid:

expected the bug to target the "4.12.0" version, but it targets "4.12" instead
expected Jira Issue OCPBUGS-2979 to depend on a bug targeting a version in 4.13.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Elbehery · 2022-10-31T12:29:19Z

/jira refresh

openshift-ci-robot · 2022-10-31T12:29:22Z

@Elbehery: This pull request references Jira Issue OCPBUGS-2979, which is invalid:

expected Jira Issue OCPBUGS-2979 to depend on a bug targeting a version in 4.13.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Elbehery · 2022-10-31T12:29:51Z

@tjungblu can we skip the required dependant bug ?

tjungblu · 2022-10-31T12:33:01Z

yeah I guess that makes sense, either @hasbro17 or @dusk125 can override this

dusk125 · 2022-10-31T13:20:04Z

/override bugzilla/valid-bug

openshift-ci · 2022-10-31T13:20:17Z

@dusk125: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

bugzilla/valid-bug

Only the following failed contexts/checkruns were expected:

ci/prow/e2e-agnostic-ovn
ci/prow/e2e-agnostic-ovn-upgrade
ci/prow/e2e-aws-ovn-serial
ci/prow/e2e-aws-ovn-single-node
ci/prow/e2e-gcp-disruptive-ovn
ci/prow/e2e-operator
ci/prow/images
ci/prow/unit
ci/prow/verify
ci/prow/verify-deps
pull-ci-openshift-cluster-etcd-operator-master-e2e-agnostic-ovn
pull-ci-openshift-cluster-etcd-operator-master-e2e-agnostic-ovn-upgrade
pull-ci-openshift-cluster-etcd-operator-master-e2e-aws-ovn-serial
pull-ci-openshift-cluster-etcd-operator-master-e2e-aws-ovn-single-node
pull-ci-openshift-cluster-etcd-operator-master-e2e-gcp-disruptive-ovn
pull-ci-openshift-cluster-etcd-operator-master-e2e-operator
pull-ci-openshift-cluster-etcd-operator-master-images
pull-ci-openshift-cluster-etcd-operator-master-unit
pull-ci-openshift-cluster-etcd-operator-master-verify
pull-ci-openshift-cluster-etcd-operator-master-verify-deps
tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override bugzilla/valid-bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dusk125 · 2022-10-31T13:21:57Z

/label bugzilla/valid-bug

openshift-ci · 2022-10-31T13:22:24Z

@dusk125: Can not set label bugzilla/valid-bug: Must be member in one of these teams: [openshift-patch-managers openshift-staff-engineers]

Details

In response to this:

/label bugzilla/valid-bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dusk125 · 2022-10-31T13:22:33Z

/approve

Elbehery · 2022-10-31T13:32:23Z

thanks @dusk125 for your attempts :)

@deads2k would you kindly label this as valid bug ?

There is no dependant bug on 4.13 .. I just missed merging this in 4.12 with few hours :)

Elbehery · 2022-10-31T13:53:13Z

/retest-required

Elbehery · 2022-10-31T16:01:04Z

/retest-required

deads2k · 2022-10-31T18:21:07Z

already merged in master,

Elbehery · 2022-10-31T19:14:52Z

/retest-required

Elbehery · 2022-11-01T04:34:15Z

/retest-required

geliu2016

/label cherry-pick-approved

openshift-ci · 2022-11-01T05:04:02Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dusk125, Elbehery, geliu2016, openshift-cherrypick-robot, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [dusk125]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tjungblu · 2022-11-01T07:45:51Z

/retest-required

openshift-ci · 2022-11-01T10:57:51Z

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-disruptive-ovn	`9ea48d5`	link	false	`/test e2e-gcp-disruptive-ovn`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2022-11-01T11:01:58Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

openshift/cluster-etcd-operator#960

Jira Issue OCPBUGS-2979 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #947

/assign Elbehery

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Elbehery added 5 commits October 31, 2022 12:06

ETCD-328: automatic replacement of an unhealthy member machine

4ce6215

add tests

5d47ed5

fix log err msgs

bc72ff7

remove duplicate quorum calculation

59942c2

add tests

9ea48d5

openshift-cherrypick-robot assigned Elbehery Oct 31, 2022

openshift-cherrypick-robot mentioned this pull request Oct 31, 2022

ETCD-328: automatic replacement of an unhealthy member machine #947

Merged

openshift-ci bot requested review from Elbehery and dusk125 October 31, 2022 12:07

openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 31, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2022

openshift-ci bot assigned dusk125, geliu2016 and tjungblu Oct 31, 2022

openshift-ci bot changed the title ~~[release-4.12] ETCD-328: automatic replacement of an unhealthy member machine~~ [release-4.12] OCPBUGS-2979: automatic replacement of an unhealthy member machine Oct 31, 2022

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 31, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2022

geliu2016 approved these changes Nov 1, 2022

View reviewed changes

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 1, 2022

openshift-merge-robot merged commit 302b68f into openshift:release-4.12 Nov 1, 2022

Conversation

openshift-cherrypick-robot commented Oct 31, 2022

Uh oh!

Elbehery commented Oct 31, 2022

Uh oh!

Elbehery commented Oct 31, 2022

Uh oh!

Elbehery commented Oct 31, 2022

Uh oh!

tjungblu commented Oct 31, 2022

Uh oh!

tjungblu commented Oct 31, 2022

Uh oh!

Elbehery commented Oct 31, 2022

Uh oh!

Elbehery commented Oct 31, 2022

Uh oh!

openshift-ci bot commented Oct 31, 2022

Uh oh!

openshift-ci-robot commented Oct 31, 2022

Uh oh!

Elbehery commented Oct 31, 2022

Uh oh!

Elbehery commented Oct 31, 2022

Uh oh!

openshift-ci-robot commented Oct 31, 2022

Uh oh!

Elbehery commented Oct 31, 2022

Uh oh!

openshift-ci-robot commented Oct 31, 2022

Uh oh!

Elbehery commented Oct 31, 2022

Uh oh!

tjungblu commented Oct 31, 2022

Uh oh!

dusk125 commented Oct 31, 2022

Uh oh!

openshift-ci bot commented Oct 31, 2022

Uh oh!

dusk125 commented Oct 31, 2022

Uh oh!

openshift-ci bot commented Oct 31, 2022

Uh oh!

dusk125 commented Oct 31, 2022

Uh oh!

Elbehery commented Oct 31, 2022

Uh oh!

Elbehery commented Oct 31, 2022

Uh oh!

Elbehery commented Oct 31, 2022

Uh oh!

deads2k commented Oct 31, 2022

Uh oh!

Elbehery commented Oct 31, 2022

Uh oh!

Elbehery commented Nov 1, 2022

Uh oh!

geliu2016 left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Nov 1, 2022

Uh oh!

tjungblu commented Nov 1, 2022

Uh oh!

openshift-ci bot commented Nov 1, 2022

Uh oh!

openshift-ci-robot commented Nov 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants