CNTRLPLANE-2683: Add network policies to openshift-etcd pods#1541
CNTRLPLANE-2683: Add network policies to openshift-etcd pods#1541dusk125 wants to merge 2 commits intoopenshift:release-4.23from
Conversation
|
@dusk125: This pull request references CNTRLPLANE-2683 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.23.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dusk125 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@dusk125: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@dusk125: This pull request references CNTRLPLANE-2683 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.23.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label tide/merge-method-squash |
|
Accidentally opened this against openshift-4.23 and not main... closing in favor of #1544 |
This PR adds network policies for the pods that exist in the openshift-etcd namespace that are managed by the cluster-etcd-operator: guard, installer, revision pruner pods.
It was suggested to have an empty policy for etcd (as it's a hostNetwork pod so ignores network policies), to act as documentation and proof that it wasn't accidentally missed.