Skip to content

CNTRLPLANE-2683: Add network policies to openshift-etcd pods#1541

Closed
dusk125 wants to merge 2 commits intoopenshift:release-4.23from
dusk125:etcd-network-policy
Closed

CNTRLPLANE-2683: Add network policies to openshift-etcd pods#1541
dusk125 wants to merge 2 commits intoopenshift:release-4.23from
dusk125:etcd-network-policy

Conversation

@dusk125
Copy link
Contributor

@dusk125 dusk125 commented Feb 4, 2026

This PR adds network policies for the pods that exist in the openshift-etcd namespace that are managed by the cluster-etcd-operator: guard, installer, revision pruner pods.

It was suggested to have an empty policy for etcd (as it's a hostNetwork pod so ignores network policies), to act as documentation and proof that it wasn't accidentally missed.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 4, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 4, 2026

@dusk125: This pull request references CNTRLPLANE-2683 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.23.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link

coderabbitai bot commented Feb 4, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 4, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dusk125

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 4, 2026

@dusk125: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-serial-1of2 7d7a112 link true /test e2e-aws-ovn-serial-1of2
ci/prow/unit 7d7a112 link true /test unit
ci/prow/e2e-aws-ovn-single-node 7d7a112 link true /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 4, 2026

@dusk125: This pull request references CNTRLPLANE-2683 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.23.0" version, but no target version was set.

Details

In response to this:

This PR adds network policies for the pods that exist in the openshift-etcd namespace that are managed by the cluster-etcd-operator: guard, installer, revision pruner pods.

It was suggested to have an empty policy for etcd (as it's a hostNetwork pod so ignores network policies), to act as documentation and proof that it wasn't accidentally missed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dusk125
Copy link
Contributor Author

dusk125 commented Feb 5, 2026

/label tide/merge-method-squash

@dusk125
Copy link
Contributor Author

dusk125 commented Feb 5, 2026

Accidentally opened this against openshift-4.23 and not main... closing in favor of #1544

@dusk125 dusk125 closed this Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants