Skip to content

Conversation

@lance5890
Copy link
Contributor

@lance5890 lance5890 commented Jun 11, 2025

as the grafana-dashboard-etcd has beed added the "'release.openshift.io/delete': "true"" annotation since 4.11, but now the newest version has no longer need this redundant file in ceo

address openshift/cluster-version-operator#1207

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 11, 2025
@openshift-ci-robot
Copy link

@lance5890: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 11, 2025
@openshift-ci openshift-ci bot requested review from Elbehery and hasbro17 June 11, 2025 02:07
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 11, 2025

Hi @lance5890. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tjungblu
Copy link
Contributor

/lgtm

thanks @lance5890 for the continued cleanup!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance5890, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3cca1e7 and 2 for PR HEAD e3ae2b9 in total

@lance5890
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 11, 2025

@lance5890: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lance5890
Copy link
Contributor Author

lance5890 commented Jun 12, 2025

/lgtm

thanks @lance5890 for the continued cleanup!

so many failed e2e cases!!! but seems unrelated to the PR,maybe we should do something to reduce unnecessary e2e failure cases, this may lead to a waste of computing resources

@tjungblu
Copy link
Contributor

I'll override, no worries.

/override ci/prow/e2e-aws-ovn-etcd-scaling
/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-aws-cpms

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 12, 2025

@tjungblu: Overrode contexts on behalf of tjungblu: ci/prow/e2e-aws-cpms, ci/prow/e2e-aws-ovn-etcd-scaling, ci/prow/e2e-aws-ovn-serial

Details

In response to this:

I'll override, no worries.

/override ci/prow/e2e-aws-ovn-etcd-scaling
/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-aws-cpms

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 12, 2025

@lance5890: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-etcd-certrotation e3ae2b9 link false /test e2e-aws-etcd-certrotation
ci/prow/e2e-aws-disruptive-ovn e3ae2b9 link false /test e2e-aws-disruptive-ovn
ci/prow/e2e-vsphere-ovn-etcd-scaling e3ae2b9 link false /test e2e-vsphere-ovn-etcd-scaling
ci/prow/configmap-scale e3ae2b9 link false /test configmap-scale
ci/prow/e2e-aws-disruptive e3ae2b9 link false /test e2e-aws-disruptive
ci/prow/e2e-metal-ovn-ha-cert-rotation-shutdown e3ae2b9 link false /test e2e-metal-ovn-ha-cert-rotation-shutdown
ci/prow/e2e-metal-ovn-sno-cert-rotation-shutdown e3ae2b9 link false /test e2e-metal-ovn-sno-cert-rotation-shutdown
ci/prow/e2e-azure-ovn-etcd-scaling e3ae2b9 link false /test e2e-azure-ovn-etcd-scaling
ci/prow/e2e-gcp-ovn-etcd-scaling e3ae2b9 link false /test e2e-gcp-ovn-etcd-scaling
ci/prow/e2e-gcp-disruptive e3ae2b9 link false /test e2e-gcp-disruptive
ci/prow/e2e-aws-etcd-recovery e3ae2b9 link false /test e2e-aws-etcd-recovery
ci/prow/e2e-gcp-disruptive-ovn e3ae2b9 link false /test e2e-gcp-disruptive-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit bc92aab into openshift:main Jun 12, 2025
20 of 32 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: cluster-etcd-operator
This PR has been included in build cluster-etcd-operator-container-v4.20.0-202506120915.p0.gbc92aab.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants