Skip to content

ETCD-688: add readyZ for restore pods#1367

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
tjungblu:ETCD-688
Nov 13, 2024
Merged

ETCD-688: add readyZ for restore pods#1367
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
tjungblu:ETCD-688

Conversation

@tjungblu
Copy link
Contributor

@tjungblu tjungblu commented Nov 11, 2024

No description provided.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 11, 2024 •
edited by openshift-ci bot
Loading

@tjungblu: This pull request references ETCD-688 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 11, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 11, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tjungblu tjungblu marked this pull request as ready for review November 11, 2024 15:40
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 11, 2024
@openshift-ci openshift-ci bot requested review from Elbehery and hasbro17 November 11, 2024 15:41
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2024
@Elbehery
Copy link
Contributor

Elbehery commented Nov 11, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2024
@tjungblu
Copy link
Contributor Author

tjungblu commented Nov 11, 2024

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2024
@tjungblu tjungblu force-pushed the ETCD-688 branch 2 times, most recently from aeca3a7 to a8c8ea7 Compare November 12, 2024 14:37
@tjungblu
ETCD-688: add readyZ for restore pods
9434853 
Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
@tjungblu
Copy link
Contributor Author

tjungblu commented Nov 13, 2024

@Elbehery can you LGTM here again please?

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2024
@Elbehery
Copy link
Contributor

Elbehery commented Nov 13, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Elbehery, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 13, 2024

/retest-required

Remaining retests: 0 against base HEAD 0079c87 and 2 for PR HEAD 9434853 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 13, 2024 •
edited
Loading

@tjungblu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ovn-sno-cert-rotation-shutdown 9434853 link false /test e2e-metal-ovn-sno-cert-rotation-shutdown
ci/prow/e2e-aws-etcd-recovery 9434853 link false /test e2e-aws-etcd-recovery
ci/prow/e2e-aws-etcd-certrotation 9434853 link false /test e2e-aws-etcd-certrotation
ci/prow/e2e-metal-ovn-ha-cert-rotation-shutdown 9434853 link false /test e2e-metal-ovn-ha-cert-rotation-shutdown

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tjungblu
Copy link
Contributor Author

tjungblu commented Nov 13, 2024

/override ci/prow/e2e-agnostic-ovn

unrelated failure to this PR

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 13, 2024

@tjungblu: Overrode contexts on behalf of tjungblu: ci/prow/e2e-agnostic-ovn

Details

In response to this:

/override ci/prow/e2e-agnostic-ovn

unrelated failure to this PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 9a2aa20 into openshift:master Nov 13, 2024
@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 14, 2024

[ART PR BUILD NOTIFIER]

Distgit: cluster-etcd-operator
This PR has been included in build cluster-etcd-operator-container-v4.19.0-202411140108.p0.g9a2aa20.assembly.stream.el9.
All builds following this will include this PR.

@lance5890 lance5890 mentioned this pull request Nov 4, 2025
Open
JoelSpeed added a commit to JoelSpeed/cluster-etcd-operator that referenced this pull request Jan 19, 2026
@JoelSpeed
Revert "Merge pull request openshift#1367 from tjungblu/ETCD-688"
afc8f52 
This reverts commit 9a2aa20, reversing
changes made to 0079c87.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Elbehery Elbehery Awaiting requested review from Elbehery

@hasbro17 hasbro17 Awaiting requested review from hasbro17

Assignees

@Elbehery Elbehery

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tjungblu @openshift-ci-robot @Elbehery @openshift-bot