[release-4.19] OCPBUGS-59228,OCPBUGS-59229: fix: clusteroperator: do not update status.relatedobjects if only order changed by openshift-cherrypick-robot · Pull Request #332 · openshift/cluster-capi-operator

openshift-cherrypick-robot · 2025-07-11T06:46:15Z

This is an automated cherry-pick of #331

/assign damdo

…er has changed

making it check against full current vs desired status values and only patch if there is a relevant change.

openshift-ci-robot · 2025-07-11T06:46:34Z

@openshift-cherrypick-robot: Jira Issue OCPBUGS-58880 has been cloned as Jira Issue OCPBUGS-59228. Will retitle bug to link to clone.

Jira Issue OCPBUGS-56805 has been cloned as Jira Issue OCPBUGS-59229. Will retitle bug to link to clone.
/retitle [release-4.19] OCPBUGS-59228,OCPBUGS-59229: fix: clusteroperator: do not update status.relatedobjects if only order changed

Details

In response to this:

This is an automated cherry-pick of #331

/assign damdo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-07-11T06:46:51Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-59228, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected dependent Jira Issue OCPBUGS-58880 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-59229, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected dependent Jira Issue OCPBUGS-56805 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #331

/assign damdo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

damdo

/approve

openshift-ci · 2025-07-11T07:39:52Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [damdo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

damdo · 2025-07-11T12:16:25Z

/label backport-risk-assessed

damdo

/lgtm

damdo · 2025-07-14T06:56:56Z

/jira refresh

openshift-ci-robot · 2025-07-14T06:57:02Z

@damdo: This pull request references Jira Issue OCPBUGS-59228, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

This pull request references Jira Issue OCPBUGS-59229, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

damdo · 2025-07-14T07:31:56Z

/jira refresh

openshift-ci-robot · 2025-07-14T07:32:09Z

@damdo: This pull request references Jira Issue OCPBUGS-59228, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.z) matches configured target version for branch (4.19.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-58880 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-58880 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0
bug has dependents

Requesting review from QA contact:
/cc @sunzhaohua2

This pull request references Jira Issue OCPBUGS-59229, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.z) matches configured target version for branch (4.19.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-56805 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-56805 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0
bug has dependents

Requesting review from QA contact:
/cc @sunzhaohua2

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

damdo · 2025-07-14T07:32:35Z

cc. @huali9 @miyadav
Would you be able to help with this backport? Thanks!

huali9 · 2025-07-15T01:28:21Z

/label qe-approved

no errors in cluser-capi-operator logs

liuhuali@Lius-MacBook-Pro huali-test % oc -n openshift-cluster-api logs -f cluster-capi-operator-784d68bfc6-fzzdv | grep "Reconciler error" | grep "clusteroperator" 
Defaulted container "cluster-capi-operator" out of: cluster-capi-operator, machine-api-migration
^C

openshift-ci-robot · 2025-07-15T01:28:46Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-59228, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.z) matches configured target version for branch (4.19.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-58880 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-58880 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0
bug has dependents

Requesting review from QA contact:
/cc @sunzhaohua2

This pull request references Jira Issue OCPBUGS-59229, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.z) matches configured target version for branch (4.19.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-56805 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-56805 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0
bug has dependents

Requesting review from QA contact:
/cc @sunzhaohua2

Details

In response to this:

This is an automated cherry-pick of #331

/assign damdo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-07-15T02:01:56Z

/retest-required

Remaining retests: 0 against base HEAD 2322035 and 2 for PR HEAD a1a8bf0 in total

damdo · 2025-07-15T06:46:18Z

/override ci/prow/e2e-openstack-ovn-techpreview

CI is having unrelated issues

openshift-ci · 2025-07-15T06:46:31Z

@damdo: Overrode contexts on behalf of damdo: ci/prow/e2e-openstack-ovn-techpreview

Details

In response to this:

/override ci/prow/e2e-openstack-ovn-techpreview

CI is having unrelated issues

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2025-07-15T06:46:34Z

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/regression-clusterinfra-aws-ipi-techpreview-capi	`a1a8bf0`	link	false	`/test regression-clusterinfra-aws-ipi-techpreview-capi`
ci/prow/e2e-openstack-ovn-techpreview	`a1a8bf0`	link	true	`/test e2e-openstack-ovn-techpreview`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

damdo · 2025-07-15T06:46:53Z

/tide refresh

openshift-ci-robot · 2025-07-15T06:51:20Z

@openshift-cherrypick-robot: Jira Issue OCPBUGS-59228: All pull requests linked via external trackers have merged:

openshift/cluster-capi-operator#332

Jira Issue OCPBUGS-59228 has been moved to the MODIFIED state.

Jira Issue OCPBUGS-59229: All pull requests linked via external trackers have merged:

openshift/cluster-capi-operator#332

Jira Issue OCPBUGS-59229 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #331

/assign damdo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot · 2025-07-15T09:22:36Z

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-capi-operator
This PR has been included in build ose-cluster-capi-operator-container-v4.19.0-202507150837.p0.gcf9e6e9.assembly.stream.el9.
All builds following this will include this PR.

damdo added 2 commits July 11, 2025 06:46

fix: clusteroperator: do not update status.relatedobjects if only ord…

27bd915

…er has changed

improve clusteroperator SyncStatus() logic

a1a8bf0

making it check against full current vs desired status values and only patch if there is a relevant change.

openshift-cherrypick-robot assigned damdo Jul 11, 2025

openshift-cherrypick-robot mentioned this pull request Jul 11, 2025

OCPBUGS-58880,OCPBUGS-56805: fix: clusteroperator: do not update status.relatedobjects if only order changed #331

Merged

openshift-ci bot changed the title ~~[release-4.19] OCPBUGS-58880,OCPBUGS-56805: fix: clusteroperator: do not update status.relatedobjects if only order changed~~ [release-4.19] OCPBUGS-59228,OCPBUGS-59229: fix: clusteroperator: do not update status.relatedobjects if only order changed Jul 11, 2025

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 11, 2025

openshift-ci bot requested review from nrb and theobarberbany July 11, 2025 06:46

damdo reviewed Jul 11, 2025

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2025

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jul 11, 2025

openshift-ci bot assigned huali9, miyadav and sunzhaohua2 Jul 11, 2025

damdo reviewed Jul 11, 2025

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2025

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jul 14, 2025

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jul 14, 2025

openshift-ci bot requested a review from sunzhaohua2 July 14, 2025 07:32

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jul 15, 2025

openshift-merge-bot bot merged commit cf9e6e9 into openshift:release-4.19 Jul 15, 2025
23 of 24 checks passed

Conversation

openshift-cherrypick-robot commented Jul 11, 2025

Uh oh!

openshift-ci-robot commented Jul 11, 2025

Uh oh!

openshift-ci-robot commented Jul 11, 2025

Uh oh!

damdo left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Jul 11, 2025

Uh oh!

damdo commented Jul 11, 2025

Uh oh!

damdo left a comment

Choose a reason for hiding this comment

Uh oh!

damdo commented Jul 14, 2025

Uh oh!

openshift-ci-robot commented Jul 14, 2025

Uh oh!

damdo commented Jul 14, 2025

Uh oh!

openshift-ci-robot commented Jul 14, 2025

Uh oh!

damdo commented Jul 14, 2025

Uh oh!

huali9 commented Jul 15, 2025

Uh oh!

openshift-ci-robot commented Jul 15, 2025

Uh oh!

openshift-ci-robot commented Jul 15, 2025

Uh oh!

damdo commented Jul 15, 2025

Uh oh!

openshift-ci bot commented Jul 15, 2025

Uh oh!

openshift-ci bot commented Jul 15, 2025

Uh oh!

damdo commented Jul 15, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Jul 15, 2025

Uh oh!

openshift-bot commented Jul 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants