TRT-2048: Revert "OCPCLOUD-2792: corecluster: set controller level conditions + tests"

[xueqzhan]

Reverts #256; tracked by https://issues.redhat.com/browse/OCPBUGS-52848

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

This PR has caused samples operator to fail during installation starting from this payload: https://sippy.dptools.openshift.org/sippy-ng/release/4.19/tags/4.19.0-0.nightly-2025-03-05-232901/pull_requests

Slack thread: https://redhat-internal.slack.com/archives/C01CQA76KMX/p1741634385702679

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of (job/X or job/X, test/Y tuple) to confirm the fix has corrected the problem:

/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial

CC: @damdo

[openshift-ci-robot]

@xueqzhan: This pull request references OCPCLOUD-2792 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Reverts #256

/hold

Please ignore. We are testing a payload failure with this

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[xueqzhan]

/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial
/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial

[openshift-ci]

@xueqzhan: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial
• periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1dea9e10-0408-11f0-9b11-9b1da6f50cfe-0

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign radekmanak for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[xueqzhan]

/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial
/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial

[openshift-ci]

@xueqzhan: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial
• periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f1e28ac0-0417-11f0-8678-c154cd968546-0

[openshift-ci-robot]

@xueqzhan: This pull request references TRT-2048 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Reverts #256

/hold

Please ignore. We are testing a payload failure with this

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@xueqzhan: This pull request references TRT-2048 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Reverts #256; tracked by

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

This PR has caused samples operator to fail during installation starting from this payload: https://sippy.dptools.openshift.org/sippy-ng/release/4.19/tags/4.19.0-0.nightly-2025-03-05-232901/pull_requests

Slack thread: https://redhat-internal.slack.com/archives/C01CQA76KMX/p1741634385702679

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of (job/X or job/X, test/Y tuple) to confirm the fix has corrected the problem:

/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial

CC: , ,

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@xueqzhan: This pull request references TRT-2048 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Reverts #256; tracked by

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

This PR has caused samples operator to fail during installation starting from this payload: https://sippy.dptools.openshift.org/sippy-ng/release/4.19/tags/4.19.0-0.nightly-2025-03-05-232901/pull_requests

Slack thread: https://redhat-internal.slack.com/archives/C01CQA76KMX/p1741634385702679

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of (job/X or job/X, test/Y tuple) to confirm the fix has corrected the problem:

/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial

CC: damdo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@xueqzhan: This pull request references TRT-2048 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Reverts #256; tracked by

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

This PR has caused samples operator to fail during installation starting from this payload: https://sippy.dptools.openshift.org/sippy-ng/release/4.19/tags/4.19.0-0.nightly-2025-03-05-232901/pull_requests

Slack thread: https://redhat-internal.slack.com/archives/C01CQA76KMX/p1741634385702679

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of (job/X or job/X, test/Y tuple) to confirm the fix has corrected the problem:

/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial

CC: @damdo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@xueqzhan: This pull request references TRT-2048 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Reverts #256; tracked by https://issues.redhat.com/browse/OCPBUGS-52848

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

This PR has caused samples operator to fail during installation starting from this payload: https://sippy.dptools.openshift.org/sippy-ng/release/4.19/tags/4.19.0-0.nightly-2025-03-05-232901/pull_requests

Slack thread: https://redhat-internal.slack.com/archives/C01CQA76KMX/p1741634385702679

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of (job/X or job/X, test/Y tuple) to confirm the fix has corrected the problem:

/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial

CC: @damdo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[xueqzhan]

/retest

[xueqzhan]

/label lgtm
/label approved

[openshift-ci]

@xueqzhan: The label(s) /label lgtm cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, ux-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, stability-fix-approved, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

Details

In response to this:

/label lgtm
/label approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[xueqzhan]

/lgtm

[openshift-ci]

@xueqzhan: you cannot LGTM your own PR.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[stbenjam]

/lgtm

[sosiouxme]

/retest

[sosiouxme]

... although given it takes 3+ hours to run i imagine you want to override

[openshift-ci]

@xueqzhan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/regression-clusterinfra-cucushift-rehearse-capi-aws-ipi	3519eb0	link	false	/test regression-clusterinfra-cucushift-rehearse-capi-aws-ipi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[xueqzhan]

/hold cancel