Skip to content

Conversation

@eggfoobar
Copy link
Contributor

@eggfoobar eggfoobar commented Oct 31, 2024

Per EP: openshift/enhancements#1674

The EP supports a new cluster topology called HighlyAvailableArbiter, this topology means that there will be 2 regular nodes and 1 arbiter less powerful node to help maintain HA. This PR updates the minimum pod count to 2 for HighlyAvailableArbiter topologies since the pods will only be running on the full sized master nodes and not in the arbiter node.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 31, 2024
@openshift-ci openshift-ci bot requested review from ibihim and liouk October 31, 2024 05:56
@eggfoobar eggfoobar force-pushed the add-arbiter-node-minimum branch from 073ca2e to 83754c1 Compare November 6, 2024 04:37
@eggfoobar eggfoobar changed the title WIP: feat: change minimum for arbiter ha deployments WIP: OCPEDGE-1306: feat: change minimum for arbiter ha deployments Nov 18, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 18, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 18, 2024

@eggfoobar: This pull request references OCPEDGE-1306 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eggfoobar eggfoobar force-pushed the add-arbiter-node-minimum branch from 83754c1 to 0515f14 Compare December 11, 2024 19:18
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 11, 2024

@eggfoobar: This pull request references OCPEDGE-1306 which is a valid jira issue.

In response to this:

Per EP: openshift/enhancements#1674

The EP supports a new cluster topology called HighlyAvailableArbiter, this topology means that there will be 2 regular nodes and 1 arbiter less powerful node to help maintain HA. This PR updates the minimum pod count to 2 for HighlyAvailableArbiter topologies since the pods will only be running on the full sized master nodes and not in the arbiter node.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eggfoobar eggfoobar changed the title WIP: OCPEDGE-1306: feat: change minimum for arbiter ha deployments OCPEDGE-1306: feat: change minimum for arbiter ha deployments Dec 11, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 11, 2024
@eggfoobar eggfoobar force-pushed the add-arbiter-node-minimum branch from 0515f14 to a7f5995 Compare December 13, 2024 05:04
@eggfoobar
Copy link
Contributor Author

/test okd-scos-e2e-aws-ovn

@ibihim
Copy link
Contributor

ibihim commented Dec 19, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2024
@deads2k
Copy link
Contributor

deads2k commented Jan 13, 2025

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2025
Signed-off-by: ehila <ehila@redhat.com>
@eggfoobar eggfoobar force-pushed the add-arbiter-node-minimum branch from a7f5995 to c461a43 Compare January 15, 2025 16:20
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2025
@eggfoobar
Copy link
Contributor Author

Hey @ibihim when you get a chance, can I get another lgtm on this PR, I needed to rebase the dependencies.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 15, 2025

@eggfoobar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn c461a43 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-single-node c461a43 link false /test e2e-aws-single-node
ci/prow/e2e-agnostic-ipv6 c461a43 link false /test e2e-agnostic-ipv6
ci/prow/test-operator-integration c461a43 link false /test test-operator-integration

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@eggfoobar
Copy link
Contributor Author

/retest-required

@jaypoulz
Copy link

/lgtm

This code hasn't changed, it was just rebased some after some dependency updates.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, eggfoobar, ibihim, jaypoulz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eggfoobar
Copy link
Contributor Author

/label acknowledge-critical-fixes-only

Payloads seem to have stabilized, merging in change.

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Jan 20, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit c36b165 into openshift:master Jan 20, 2025
9 of 13 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-authentication-operator
This PR has been included in build ose-cluster-authentication-operator-container-v4.19.0-202501202140.p0.gc36b165.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants