Skip to content

API-1835: Add input-resources #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2024
Merged

API-1835: Add input-resources #730

merged 2 commits into from
Oct 30, 2024

Conversation

@bertinatto
Copy link
Member

@bertinatto bertinatto commented Oct 29, 2024

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 29, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 29, 2024 •
edited by openshift-ci bot
Loading

@bertinatto: This pull request references API-1835 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 29, 2024
@bertinatto bertinatto changed the title [WIP] API-1835: Add inpu-resources [WIP] API-1835: Add input-resources Oct 29, 2024
@openshift-ci openshift-ci bot requested review from ibihim and liouk October 29, 2024 23:11
p0lyn0mial
p0lyn0mial reviewed Oct 30, 2024
View reviewed changes
pkg/cmd/mom/input_resources_command.go Outdated
libraryinputresources.ExactConfigResource("consoles"),
libraryinputresources.ExactConfigResource("proxies"),
libraryinputresources.ExactResource("config.openshift.io", "v1", "clusterversions", "", "version"),
// OpenShiftx
Copy link
Contributor

@p0lyn0mial p0lyn0mial Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: typo

Copy link
Member Author

@bertinatto bertinatto Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

pkg/cmd/mom/input_resources_command.go
}

func RunInputResources(ctx context.Context) (*libraryinputresources.InputResources, error) {
return &libraryinputresources.InputResources{
Copy link
Contributor

@p0lyn0mial p0lyn0mial Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we get this list wrong then the operator will fail, right ?

Copy link
Contributor

@deads2k deads2k Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we get this list wrong then the operator will fail, right ?

discussed on the call. to be added.

@bertinatto bertinatto changed the title [WIP] API-1835: Add input-resources API-1835: Add input-resources Oct 30, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 30, 2024
@deads2k
Copy link
Contributor

deads2k commented Oct 30, 2024

/lgtm
/approve
/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2024
@bertinatto
Copy link
Member Author

bertinatto commented Oct 30, 2024

/test test-operator-integration

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2024

@bertinatto: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-single-node 5d898b2 link false /test e2e-aws-single-node
ci/prow/e2e-agnostic-ipv6 5d898b2 link false /test e2e-agnostic-ipv6
ci/prow/test-operator-integration 5d898b2 link false /test test-operator-integration

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit f9722a2 into openshift:master Oct 30, 2024
9 of 12 checks passed
@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 30, 2024

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-authentication-operator
This PR has been included in build ose-cluster-authentication-operator-container-v4.18.0-202410301937.p0.gf9722a2.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k deads2k left review comments

@ibihim ibihim Awaiting requested review from ibihim

@liouk liouk Awaiting requested review from liouk

+1 more reviewer

@p0lyn0mial p0lyn0mial p0lyn0mial left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@deads2k deads2k

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bertinatto @openshift-ci-robot @deads2k @openshift-bot @p0lyn0mial