API-1835: Bump library-go to get SSA in multiple controllers #721
Conversation
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
@bertinatto: This pull request references API-1835 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
bertinatto
changed the title
bertinatto
force-pushed
the
try-apply-multiple-controllers
branch
3 times, most recently
from
d28bf43 to
adaa805
Compare
|
/payload-job periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn |
|
@bertinatto: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ad0f2b20-9148-11ef-9590-4792b3fe2ec2-0 |
bertinatto
force-pushed
the
try-apply-multiple-controllers
branch
from
adaa805 to
bdbbca9
Compare
|
/payload-job periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn |
|
@bertinatto: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/551e7780-9225-11ef-9c13-c4fec185a20f-0 |
bertinatto
force-pushed
the
try-apply-multiple-controllers
branch
2 times, most recently
from
9f5bd70 to
20a1ad6
Compare
bertinatto
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@bertinatto: This pull request references API-1835 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/override ci/prow/e2e-operator |
openshift-merge-robot
added
the
needs-rebase
|
@deads2k: Overrode contexts on behalf of deads2k: ci/prow/e2e-operator In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-ci
bot
added
lgtm
pkg/operator/replacement_starter.go
Outdated
| ret.ControllerRunOnceFns = append(ret.ControllerRunOnceFns, libraryapplyconfiguration.AdaptSyncFn(authOperatorInput.eventRecorder, resourceSyncer.Sync)) | ||
|
|
||
| configOverridesController := unsupportedconfigoverridescontroller.NewUnsupportedConfigOverridesController(authOperatorInput.authenticationOperatorClient, authOperatorInput.eventRecorder) | ||
| configOverridesController := unsupportedconfigoverridescontroller.NewUnsupportedConfigOverridesController("openshift-auhentication", authOperatorInput.authenticationOperatorClient, authOperatorInput.eventRecorder) |
There was a problem hiding this comment.
if you're rebasing anyway, fix the typo in authentication.
bertinatto
force-pushed
the
try-apply-multiple-controllers
branch
from
20a1ad6 to
bc38d8d
Compare
openshift-merge-robot
removed
the
needs-rebase
bertinatto
force-pushed
the
try-apply-multiple-controllers
branch
from
bc38d8d to
9689315
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
8 similar comments
|
@bertinatto: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/override ci/prow/e2e-operator |
|
@deads2k: Overrode contexts on behalf of deads2k: ci/prow/e2e-operator In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
bot
merged commit fa0aa49
into
openshift:master
4 participants
/assign @deads2k @p0lyn0mial