Skip to content

Bump kube 1.16 #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 3, 2019
Merged

Bump kube 1.16 #76

merged 5 commits into from
Oct 3, 2019

Conversation

enxebre
Copy link
Member

@enxebre enxebre commented Oct 1, 2019

Bump libraries to kube 1.16.0
/hold
needs kubernetes-sigs/controller-runtime#618

Follow ups:

  • Drop unused code carried over form upstream
  • Drop bazel
  • Move to go modules

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 1, 2019
Copy link

@bison bison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bison

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2019
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2019
@enxebre
Copy link
Member Author

enxebre commented Oct 1, 2019

/test unit

@enxebre
Copy link
Member Author

enxebre commented Oct 1, 2019

/test unit

@enxebre enxebre force-pushed the bump-kube-1.16 branch 2 times, most recently from ad3632d to a6bfb98 Compare October 1, 2019 16:21
@enxebre
Copy link
Member Author

enxebre commented Oct 2, 2019

/test unit

@enxebre
Copy link
Member Author

enxebre commented Oct 3, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2019
@enxebre enxebre merged commit 24cfb34 into openshift:master Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants