Bump k8s to 1.14.1 #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ingvagabund
commented
May 22, 2019
ingvagabund
commented
- bump k8s to v1.14.1
- Manager.GetRecorder renamed to Manager.GetEventRecorderFor
- replace "-" with "_" in controller names (the name is used to prefix prometheus metric name which refuses "-" in metric name, see ⚠ Bump Kubernetes version to 1.14 kubernetes-sigs/controller-runtime#376)
- machineset-controller -> machineset_controller
- machinedeployment-controller -> machinedeployment_controller
- cluster-controller -> cluster_controller
- replace order of arguments in Client.List (runtime object switched with list options, list options converted to a function)
- schema moved from "sigs.k8s.io/controller-runtime/pkg/runtime/schema" under "sigs.k8s.io/controller-runtime/pkg/scheme"
- "k8s.io/client-go/util/integer" moved under "k8s.io/utils/integer"
openshift-ci-robot
added
the
size/XXL
|
/refresh |
|
/retest |
bison
reviewed
May 22, 2019
pkg/controller/machinedeployment/machinedeployment_controller_test.go
Outdated
Show resolved
Hide resolved
bison
reviewed
May 22, 2019
ingvagabund
force-pushed
the
bump-k8s-to-1.14.1
branch
from
415c2ac to
69d5683
Compare
frobware
reviewed
May 24, 2019
| @@ -61,7 +61,7 @@ func AddWithActuator(mgr manager.Manager, actuator Actuator) error { | |||
| func newReconciler(mgr manager.Manager, actuator Actuator) reconcile.Reconciler { | |||
| r := &ReconcileMachine{ | |||
| Client: mgr.GetClient(), | |||
| eventRecorder: mgr.GetRecorder("machine-controller"), | |||
| eventRecorder: mgr.GetEventRecorderFor("machine-controller"), | |||
There was a problem hiding this comment.
I would still prefer to keep the event source to have - instead of _.
Requires to update controller-runtime to the latest which has just recently adopted k8s v1.14.
…o/controller-runtime@master - Manager.GetRecorder renamed to Manager.GetEventRecorderFor - replace "-" with "_" in controller names (the name is used to prefix prometheus metric name which refuses "-" in metric name) - machineset-controller -> machineset_controller - machinedeployment-controller -> machinedeployment_controller - cluster-controller -> cluster_controller - replace order of arguments in Client.List (runtime object switched with list options, list options converted to a function) - schema moved from "sigs.k8s.io/controller-runtime/pkg/runtime/schema" under "sigs.k8s.io/controller-runtime/pkg/scheme" - "k8s.io/client-go/util/integer" moved under "k8s.io/utils/integer"
ingvagabund
force-pushed
the
bump-k8s-to-1.14.1
branch
from
69d5683 to
73386ff
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: frobware The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/lgtm |
openshift-merge-robot
merged commit e911af7
into
openshift:openshift-4.2-cluster-api-0.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.