Bug 1977319: cleanup orphaned Service 'controller-manager-service' #388

joelddiaz · 2021-09-24T12:11:32Z

Back in 4.1 we installed a Service named 'controller-manager-service'.
That was subsequently dropped, but any cluster that has upgraded from
4.1 to present keeps the needless Service arround. Re-create the Service
with the delete annotation so that the CVO can properly clean this up.

openshift-ci · 2021-09-24T12:11:39Z

@joelddiaz: This pull request references Bugzilla bug 1977319, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @lwan-wanglin

Details

In response to this:

Bug 1977319: cleanup orphaned Service 'controller-manager-service'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

joelddiaz · 2021-09-24T12:11:46Z

/assign @akhil-rane

akhil-rane

/lgtm

gone are the days of cleanup controller

openshift-bot · 2021-09-24T15:39:41Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-24T16:03:43Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-24T17:51:44Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

joelddiaz · 2021-09-24T18:43:14Z

/bugzilla refresh

openshift-ci · 2021-09-24T18:43:18Z

@joelddiaz: This pull request references Bugzilla bug 1977319, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @lwan-wanglin

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking · 2021-09-24T19:59:17Z

manifests/01-service-delete.yaml

+kind: Service
+metadata:
+  annotations:
+    release.openshift.io/delete: "true"


The CVO will ignore this unless you set profile annotations. Checking your other manifests:

$ git grep -oh 'include.release.openshift.io/.*' manifests | sort | uniq -c 14 include.release.openshift.io/ibm-cloud-managed: "true" 20 include.release.openshift.io/self-managed-high-availability: "true"

Wow, our manifest is so old it predates all that stuff. Thanks for the quick catch. You saved us some QE time 🥇

Back in 4.1 we installed a Service named 'controller-manager-service'. That was subsequently dropped, but any cluster that has upgraded from 4.1 to present keeps the needless Service arround. Re-create the Service with the delete annotation so that the CVO can properly clean this up.

lwan-wanglin · 2021-09-26T10:34:09Z

/label qe-approved

test pass:

installed a 4.9 cluster , and create a service controller-manager-service

$ cat 01-service.yaml 
apiVersion: v1
kind: Service
metadata:
  labels:
    control-plane: controller-manager
    controller-tools.k8s.io: "1.0"
  name: controller-manager-service
  namespace: openshift-cloud-credential-operator
spec:
  ports:
  - port: 443
  selector:
    control-plane: controller-manager
    controller-tools.k8s.io: "1.0"

Check clusterversion

$ oc get clusterversion
NAME      VERSION      AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.9.0-rc.3   True        False         7h34m   Cluster version is 4.9.0-rc.3

Check service

$ oc get service -n openshift-cloud-credential-operator
NAME                         TYPE        CLUSTER-IP      EXTERNAL-IP   PORT(S)    AGE
cco-metrics                  ClusterIP   172.30.50.225           8443/TCP   7h55m
controller-manager-service   ClusterIP   172.30.67.51            443/TCP    18m
pod-identity-webhook         ClusterIP   172.30.37.210           443/TCP    7h47m

upgrade cluster to a version with this fix

oc adm upgrade --to-image registry.build01.ci.openshift.org/ci-ln-tnfrvhb/release:latest --allow-explicit-upgrade --force
warning: Using by-tag pull specs is dangerous, and while we still allow it in combination with --force for backward compatibility, it would be much safer to pass a by-digest pull spec instead
warning: The requested upgrade image is not one of the available updates.  You have used --allow-explicit-upgrade to the update to proceed anyway
warning: --force overrides cluster verification of your supplied release image and waives any update precondition failures.

After upgrade, check service/controller-manager-service is deleted

$ oc get service -n openshift-cloud-credential-operator
NAME                   TYPE        CLUSTER-IP      EXTERNAL-IP   PORT(S)    AGE
cco-metrics            ClusterIP   172.30.50.225           8443/TCP   8h
pod-identity-webhook   ClusterIP   172.30.37.210           443/TCP    8h

joelddiaz · 2021-10-05T15:32:05Z

/test e2e-upgrade

akhil-rane · 2021-10-11T19:17:39Z

/lgtm

openshift-ci · 2021-10-11T19:18:07Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akhil-rane, joelddiaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [akhil-rane,joelddiaz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-10-11T22:14:39Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-11T22:27:39Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-10-12T00:12:07Z

@joelddiaz: All pull requests linked via external trackers have merged:

openshift/cloud-credential-operator#388

Bugzilla bug 1977319 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1977319: cleanup orphaned Service 'controller-manager-service'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Bug 1977319: cleanup orphaned Service 'controller-manager-service'

openshift-ci bot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 24, 2021

openshift-ci bot requested a review from lwan-wanglin September 24, 2021 12:11

openshift-ci bot assigned akhil-rane Sep 24, 2021

openshift-ci bot requested review from abutcher and dgoodwin September 24, 2021 12:12

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2021

akhil-rane reviewed Sep 24, 2021

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2021

openshift-ci bot removed the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Sep 24, 2021

openshift-ci bot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Sep 24, 2021

wking reviewed Sep 24, 2021

View reviewed changes

joelddiaz force-pushed the cleanup-stale-service branch from 8aaf96f to f0499a8 Compare September 24, 2021 20:16

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2021

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 26, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2021

openshift-merge-robot merged commit 53b0ede into openshift:master Oct 12, 2021

lance5890 mentioned this pull request Jun 30, 2025

NO-JIRA: Remove deleted service yaml #880

Open

ming1013 pushed a commit to ming1013/cloud-credential-operator that referenced this pull request Dec 15, 2025

Merge pull request openshift#388 from joelddiaz/cleanup-stale-service

28ad33a

Bug 1977319: cleanup orphaned Service 'controller-manager-service'

Bug 1977319: cleanup orphaned Service 'controller-manager-service' #388

Bug 1977319: cleanup orphaned Service 'controller-manager-service' #388

Uh oh!

Conversation

joelddiaz commented Sep 24, 2021

Uh oh!

openshift-ci bot commented Sep 24, 2021

Uh oh!

joelddiaz commented Sep 24, 2021

Uh oh!

akhil-rane left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-bot commented Sep 24, 2021

Uh oh!

openshift-bot commented Sep 24, 2021

Uh oh!

openshift-bot commented Sep 24, 2021

Uh oh!

joelddiaz commented Sep 24, 2021

Uh oh!

openshift-ci bot commented Sep 24, 2021

Uh oh!

wking Sep 24, 2021

Choose a reason for hiding this comment

Uh oh!

joelddiaz Sep 24, 2021

Choose a reason for hiding this comment

Uh oh!

lwan-wanglin commented Sep 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joelddiaz commented Oct 5, 2021

Uh oh!

akhil-rane commented Oct 11, 2021

Uh oh!

openshift-ci bot commented Oct 11, 2021

Uh oh!

openshift-bot commented Oct 11, 2021

Uh oh!

openshift-bot commented Oct 11, 2021

Uh oh!

openshift-ci bot commented Oct 12, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

lwan-wanglin commented Sep 26, 2021 •

edited

Loading