SREP-21: backplane API is now allocating a remediation instance id for each call to createRemediation #19
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@Nikokolas3270: This pull request references SREP-21 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Nikokolas3270
force-pushed
the
SREP-21
branch
2 times, most recently
from
1dd56a7 to
73b8e29
Compare
…n calling createRemediation; this id will be used in place of the remediation name at deleteRemediation time. This will allow backplane to have several remediations with the same name in parallel without mixing up the resources created on the target cluster.
|
@Nikokolas3270: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
It looks good to me. |
|
LGTM |
|
/lgtm |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feichashao, MitaliBhalla, Nikokolas3270, samanthajayasinghe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
What type of PR is this?
feature
What this PR does / Why we need it?
This new id is used at deletion time (
deleteRemediation) to locate the SA & RBAC to delete.This allows to call
createRemediationseveral times with the same remediation name and not mix up the resources created on the target cluster for each call.Which Jira/Github issue(s) does this PR fix?
_Contributes to SREP-21
Special notes for your reviewer
Other PR will follows on
backplane-cliand on the other (gitlab)backplane-apirepo.Lastly CAD will be changed to support & use this new API
Pre-checks (if applicable)