Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid libvirt error during disks teardown #968

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

@openshift-ci openshift-ci bot requested review from eliorerz and omertuc July 15, 2021 13:38
@lalon4
Copy link
Contributor Author

lalon4 commented Jul 15, 2021

/cc @nshidlin

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 15, 2021
@openshift-ci openshift-ci bot requested a review from nshidlin July 15, 2021 13:38
@lalon4 lalon4 changed the title Catch libvirt error during disks teardown Avoid libvirt error during disks teardown Jul 15, 2021
@lalon4 lalon4 force-pushed the lalon-error-handling branch from 07ccb17 to 865e02b Compare July 15, 2021 15:48
Copy link
Contributor

@eliorerz eliorerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jul 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eliorerz, lalon4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2021
@openshift-merge-robot openshift-merge-robot merged commit c253526 into openshift:master Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants