Raz/mgmt 1668 #87
Closed
Raz/mgmt 1668 #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RazRegev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
RazRegev
force-pushed
the
raz/mgmt-1668
branch
2 times, most recently
from
6613ec9 to
bc0c19b
Compare
tsorya
reviewed
Aug 18, 2020
tsorya
reviewed
Aug 18, 2020
tsorya
reviewed
Aug 18, 2020
Instead of using hard coded ports (to allow multiple environments on the same host) search automatically for available ports to use for the assisted-service and ui. - the hard coded ports became 'start ports', it will start searching for a free port starting from these values. - if the namespace is already up, reuse the same ports. - if a port is spawned for another service but it is currently down for some reason, take that port. - kill_port_forwarding will delete all ports from all namespaces
list_namespaced_forwarded_ports lists all forwarded ports and services under a given namespace. list_all_forwarded_ports lists all ports of all services from all namespaces.
RazRegev
force-pushed
the
raz/mgmt-1668
branch
from
bc0c19b to
100c83e
Compare
|
@RazRegev: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
needs-rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.