Raz/mgmt 1765 deploy oc #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
needs-rebase
RazRegev
force-pushed
the
raz/MGMT-1765-deploy-oc
branch
from
9267b05 to
6c48a74
Compare
openshift-ci-robot
removed
the
needs-rebase
tsorya
reviewed
Aug 11, 2020
tsorya
reviewed
Aug 11, 2020
tsorya
reviewed
Aug 11, 2020
RazRegev
force-pushed
the
raz/MGMT-1765-deploy-oc
branch
2 times, most recently
from
2f3ce4b to
4d8631f
Compare
RazRegev
force-pushed
the
raz/MGMT-1765-deploy-oc
branch
from
4d8631f to
f7a8643
Compare
|
/lgtm |
YuviGold
suggested changes
Aug 11, 2020
tsorya
reviewed
Aug 11, 2020
RazRegev
force-pushed
the
raz/MGMT-1765-deploy-oc
branch
3 times, most recently
from
954ed1a to
7beef66
Compare
RazRegev
force-pushed
the
raz/MGMT-1765-deploy-oc
branch
2 times, most recently
from
cea4710 to
9add671
Compare
openshift-ci-robot
added
the
needs-rebase
RazRegev
force-pushed
the
raz/MGMT-1765-deploy-oc
branch
3 times, most recently
from
c10b73b to
5387da3
Compare
RazRegev
force-pushed
the
raz/MGMT-1765-deploy-oc
branch
from
9bc3fe7 to
9a34087
Compare
YuviGold
reviewed
Aug 12, 2020
YuviGold
reviewed
Aug 12, 2020
YuviGold
reviewed
Aug 12, 2020
tsorya
reviewed
Aug 12, 2020
RazRegev
force-pushed
the
raz/MGMT-1765-deploy-oc
branch
from
9a34087 to
809b7db
Compare
tsorya
reviewed
Aug 12, 2020
RazRegev
force-pushed
the
raz/MGMT-1765-deploy-oc
branch
from
809b7db to
be3c4d2
Compare
RazRegev
force-pushed
the
raz/MGMT-1765-deploy-oc
branch
from
be3c4d2 to
5ea1ee9
Compare
In order to deploy nodes against remote servers we need to be able to execute oc commands from skipper. If user wants to deploy nodes on psi he should use the token and server for the oc login command or to perform local oc-login.
RazRegev
force-pushed
the
raz/MGMT-1765-deploy-oc
branch
2 times, most recently
from
bd4295b to
77d81f3
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RazRegev, tsorya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
Determine whether to get the assisted-service url using minikube or oc by the --oc-mode flag. If oc mode, get remote url from psi. Moved url creation from outside the client creation function. Added option to override assisted-service service name since it currently might also be bm-inventory.
Added variables to makefile, skipper and README.md
RazRegev
force-pushed
the
raz/MGMT-1765-deploy-oc
branch
from
baacde8 to
f6a4a78
Compare
|
/lgtm |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.