Add support for writing Day2 API tests #599
Conversation
mchernik
commented
Mar 9, 2021
mchernik
commented
- Reuse existing TF configuration
- Always return fresh TF state
- Clear nodes cache
- Fetch reuested number of Day2 nodes from environment
|
Hi @mchernik. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
needs-ok-to-test
| self.cluster_name = kwargs.get('cluster_name', f'{consts.CLUSTER_PREFIX}' + "-" + self.cluster_suffix) | ||
| self.network_name = kwargs.get('network_name', consts.TEST_NETWORK) + self.cluster_suffix | ||
| self.network_conf = kwargs.get('net_asset') | ||
| self.cluster_domain = kwargs.get('base_domain', "redhat.com") | ||
| self.ipv6 = kwargs.get('ipv6') | ||
| self.params = self._terraform_params(**kwargs) | ||
| self.tf_folder = self._create_tf_folder() | ||
| tf_folder = kwargs.get('tf_folder') | ||
| self.tf_folder = tf_folder if tf_folder else self._create_tf_folder() |
There was a problem hiding this comment.
Any reason not to use the get default value like in cluster_suffix above?
There was a problem hiding this comment.
Yes. The default parameter to get ( _create_tf_folder() method) is evaluated before calling get, so the TF folder is always recreated with this approach.
|
/ok-to-test |
openshift-ci-robot
added
ok-to-test
- Reuse existing TF configuration - Always return fresh TF state - Clear nodes cache - Fetch reuested number of Day2 nodes from environment
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mchernik, tsorya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
