MGMT-3370: Allow running in kube api mode #505
Conversation
openshift-ci-robot
added
the
approved
RazRegev
force-pushed
the
MGMT-3370-add-kubeapi
branch
from
1f1a6f6 to
5075650
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RazRegev, tsorya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
scripts/deploy_assisted_service.sh
Outdated
| @@ -50,7 +51,7 @@ elif [ "${DEPLOY_TARGET}" == "ocp" ]; then | |||
| else | |||
| print_log "Updating assisted_service params" | |||
| skipper run discovery-infra/update_assisted_service_cm.py ENABLE_AUTH=${ENABLE_AUTH} | |||
| skipper run "make -C assisted-service/ deploy-all" ${SKIPPER_PARAMS} DEPLOY_TAG=${DEPLOY_TAG} DEPLOY_MANIFEST_PATH=${DEPLOY_MANIFEST_PATH} DEPLOY_MANIFEST_TAG=${DEPLOY_MANIFEST_TAG} NAMESPACE=${NAMESPACE} ENABLE_AUTH=${ENABLE_AUTH} PROFILE=${PROFILE} | |||
| cd assisted-service/ && skipper run "make deploy-all" ${SKIPPER_PARAMS} ENABLE_KUBE_API=${ENABLE_KUBE_API} DEPLOY_TAG=${DEPLOY_TAG} DEPLOY_MANIFEST_PATH=${DEPLOY_MANIFEST_PATH} DEPLOY_MANIFEST_TAG=${DEPLOY_MANIFEST_TAG} NAMESPACE=${NAMESPACE} ENABLE_AUTH=${ENABLE_AUTH} PROFILE=${PROFILE} | |||
There was a problem hiding this comment.
why do you cd to the directory and not running skipper run "make -C assisted-service/ deploy-all" ?
There was a problem hiding this comment.
The reason I did it because it currently runs with a test-infra skipper image.
If we want to have the dependencies to generate manifests we need to use an assisted-service build image.
I think regardless of this specific need that this would be more appropriate to use an assisted-service build image to deploy assisted-service.
There was a problem hiding this comment.
Is it because of the controller-gen?
@tsorya is there a specific reason why assisted build image wasn't used to begin with?
There was a problem hiding this comment.
yes, the controller gen is the main reason
There was a problem hiding this comment.
sounds logical i must say but it will require to create 2 build images in every deployment and will take very long time
There was a problem hiding this comment.
Then to make it work with single build container we need to install some things from this commit openshift/assisted-service@697a281
Do you think it will better?
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
By passing ENABLE_KUBE_API env. Use the skipper image of assisted-service which has all the relevant dependencies required to generate and deploy relevant definitions and deploy the service with the kube controller enabled.
RazRegev
force-pushed
the
MGMT-3370-add-kubeapi
branch
from
5075650 to
d52ccf0
Compare
|
New changes are detected. LGTM label has been removed. |
|
@RazRegev: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| @@ -50,7 +53,7 @@ elif [ "${DEPLOY_TARGET}" == "ocp" ]; then | |||
| else | |||
| print_log "Updating assisted_service params" | |||
| skipper run discovery-infra/update_assisted_service_cm.py ENABLE_AUTH=${ENABLE_AUTH} | |||
| skipper run "make -C assisted-service/ deploy-all" ${SKIPPER_PARAMS} DEPLOY_TAG=${DEPLOY_TAG} DEPLOY_MANIFEST_PATH=${DEPLOY_MANIFEST_PATH} DEPLOY_MANIFEST_TAG=${DEPLOY_MANIFEST_TAG} NAMESPACE=${NAMESPACE} ENABLE_AUTH=${ENABLE_AUTH} PROFILE=${PROFILE} | |||
| cd assisted-service/ && skipper run "make deploy-all" ${SKIPPER_PARAMS} $ENABLE_KUBE_API_CMD DEPLOY_TAG=${DEPLOY_TAG} DEPLOY_MANIFEST_PATH=${DEPLOY_MANIFEST_PATH} DEPLOY_MANIFEST_TAG=${DEPLOY_MANIFEST_TAG} NAMESPACE=${NAMESPACE} ENABLE_AUTH=${ENABLE_AUTH} PROFILE=${PROFILE} | |||
There was a problem hiding this comment.
maybe wrap it all with parenthesis so that the cd is relevant to this line alone
There was a problem hiding this comment.
Instead of doing this, maybe lets install the dependencies https://github.com/openshift/assisted-service/pull/829/files and install them in test-infra.
Then we will not need two build containers.
By passing ENABLE_KUBE_API env.
Use the skipper image of assisted-service which has all
the relevant dependencies required to generate and deploy
relevant definitions and deploy the service with the kube
controller enabled.