NO-ISSUE add FIO Image and CVO check parameters #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
irosenzw
reviewed
Jan 18, 2021
nmagnezi
reviewed
Jan 18, 2021
|
/retest |
|
/retest |
1 similar comment
|
/retest |
gamli75
approved these changes
Jan 19, 2021
|
/approved |
|
/approve |
YuviGold
reviewed
Jan 19, 2021
README.md
Outdated
| @@ -103,6 +103,8 @@ Check the [Install Guide](GUIDE.md) for installation instructions. | |||
| | SSO_URL | URL used to fetch JWT tokens for assisted-service authentication | | |||
| | WORKER_MEMORY | memory for worker VM, default: 8892MB | | |||
| | PUBLIC_CONTAINER_REGISTRIES | comma-separated list of registries that do not require authentication for pulling assisted installer images | | |||
| | FIO_PERF_CHECK_IMAGE | FIO performance check image to use, will update assisted-service config map with given value | | |||
| | CHECK_CLUSTER_VERSION | If enable, the controller will wait for CVO to finish | | |||
There was a problem hiding this comment.
What value does it need to get "enabled"? Just being set? or some value? If so - please describe it.
|
/approve |
YuviGold
approved these changes
Jan 20, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gamli75, nmagnezi, rollandf, YuviGold The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.