set_dns: skip when base_dns_domains is set

[danielerez]

Skip dnsmasq flow when BASE_DNS_DOMAINS env var is set.

[tsorya]

can u explain a little more? How it will work if base domain not set?

[tsorya]

i think i got it but can u add this pull request to previous one? and just open one with 2 commits? will be easier to follow

[danielerez]

i think i got it but can u add this pull request to previous one? and just open one with 2 commits? will be easier to follow

I'm just checking whether the env var was defaulted to an empty string in Makefile (i.e. was not defined).
But sure, added to #35.

[tsorya]

/lgtm

[tsorya]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielerez, tsorya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tsorya]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment