MGMT-3108: Adding bootstrap-in-place installation support #360

osherdp · 2020-12-24T19:08:18Z

No description provided.

discovery-infra/resources/install-config.yaml

discovery-infra/resources/sno_manifest.yaml

romfreiman · 2020-12-24T19:12:17Z

discovery-infra/test_infra/utils.py

-    timeout=consts.NODES_REGISTERED_TIMEOUT,
-    fall_on_error_status=True,
-    interval=5,
+        client,


now u like @tsorya :)

discovery-infra/resources/install-config.yaml

Makefile

terraform_files/main.tf

osherdp · 2020-12-27T13:53:03Z

/hold

tsorya · 2020-12-27T19:14:44Z

/lgtm

osherdp · 2020-12-30T11:09:09Z

/retest

osherdp · 2020-12-30T15:11:37Z

/retest

tsorya · 2020-12-30T16:04:16Z

discovery-infra/bootstrap_in_place.py

+        logging.info("Installation completed successfully!")
+
+    finally:
+        if host_ip is not None:


can we push all this to function? and just call it?

discovery-infra/bootstrap_in_place.py

tsorya · 2020-12-30T16:05:51Z

discovery-infra/bootstrap_in_place.py

+
+
+def gather_sosreport_data(host_ip):
+    with SshConnection(ip=host_ip, private_ssh_key_path=SSH_KEY) as ssh:


we have this option in Node object. Why not to use the object?

and add function that will upload file will be very helpful to there

tsorya · 2020-12-30T16:06:47Z

discovery-infra/bootstrap_in_place.py

+        ssh.upload_file(SOSREPORT_SCRIPT, "/tmp/man_sosreport.sh")
+        ssh.execute("chmod a+x /tmp/man_sosreport.sh")
+        ssh.execute("sudo /tmp/man_sosreport.sh")
+        ssh.download_file("/tmp/sosreport.tar.bz2", IBIP_DIR)


tsorya · 2020-12-30T16:07:15Z

discovery-infra/bootstrap_in_place.py

+    utils.run_command(f"{INSTALLER_BINARY} create manifests --dir={IBIP_DIR}")
+    logging.info("Installer generate ignitions")
+    # TODO delete
+    shutil.copy(f"{RESOURCES_DIR}/sno_manifest.yaml", os.path.join(IBIP_DIR, "openshift"))


@eranco74 still needed?

I'll remove it once we move to quay.io/eranco74/ocp-release:bootstrap-in-place

discovery-infra/bootstrap_in_place.py

tsorya · 2020-12-30T18:24:25Z

/approve

tsorya · 2020-12-31T08:30:35Z

/lgtm

osherdp · 2020-12-31T08:42:45Z

/unhold

eranco74 · 2020-12-31T08:40:33Z

discovery-infra/bootstrap_in_place.py

+    utils.run_command(f"{INSTALLER_BINARY} create manifests --dir={IBIP_DIR}")
+    logging.info("Installer generate ignitions")
+    # TODO delete
+    shutil.copy(f"{RESOURCES_DIR}/sno_manifest.yaml", os.path.join(IBIP_DIR, "openshift"))


I'll remove it once we move to quay.io/eranco74/ocp-release:bootstrap-in-place

eranco74 · 2020-12-31T08:42:14Z

discovery-infra/bootstrap_in_place.py

+
+    finally:
+        logging.info("Gathering sosreport data from host...")
+        node = Nodes(controller, private_ssh_key_path=SSH_KEY)[0]


Can we log the oc describe co here?

It's in the sosreport script

openshift-ci-robot · 2020-12-31T08:58:01Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eranco74, osherdp, tsorya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [eranco74,tsorya]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-12-31T09:01:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 24, 2020

openshift-ci-robot requested review from RazRegev and tsorya December 24, 2020 19:08

romfreiman reviewed Dec 24, 2020

View reviewed changes

discovery-infra/resources/install-config.yaml Show resolved Hide resolved

romfreiman reviewed Dec 24, 2020

View reviewed changes

discovery-infra/resources/sno_manifest.yaml Show resolved Hide resolved

romfreiman reviewed Dec 24, 2020

View reviewed changes

tsorya reviewed Dec 24, 2020

View reviewed changes

discovery-infra/resources/install-config.yaml Show resolved Hide resolved

tsorya reviewed Dec 24, 2020

View reviewed changes

Makefile Outdated Show resolved Hide resolved

tsorya reviewed Dec 24, 2020

View reviewed changes

terraform_files/main.tf Outdated Show resolved Hide resolved

osherdp force-pushed the test/bootstrap-in-place branch from c7b796d to 3d19315 Compare December 27, 2020 13:52

osherdp changed the title ~~[WIP] Adding bootstrap-in-place installation support~~ MGMT-3108: Adding bootstrap-in-place installation support Dec 27, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 27, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 27, 2020

openshift-ci-robot assigned tsorya Dec 27, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 27, 2020

osherdp force-pushed the test/bootstrap-in-place branch from 3d19315 to e891d98 Compare December 28, 2020 10:54

openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm Indicates that a PR is ready to be merged. labels Dec 28, 2020

osherdp force-pushed the test/bootstrap-in-place branch from e891d98 to c732fe8 Compare December 28, 2020 10:57

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 28, 2020

osherdp force-pushed the test/bootstrap-in-place branch 4 times, most recently from cba2b62 to 4364824 Compare December 30, 2020 10:16

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 30, 2020

osherdp force-pushed the test/bootstrap-in-place branch from 4364824 to f0fcf3d Compare December 30, 2020 10:26

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 30, 2020

osherdp force-pushed the test/bootstrap-in-place branch 2 times, most recently from b1bf1b1 to 1e32b34 Compare December 30, 2020 14:39

tsorya reviewed Dec 30, 2020

View reviewed changes

discovery-infra/bootstrap_in_place.py Show resolved Hide resolved

tsorya reviewed Dec 30, 2020

View reviewed changes

osherdp force-pushed the test/bootstrap-in-place branch from 1e32b34 to 89b55f8 Compare December 30, 2020 17:16

tsorya reviewed Dec 30, 2020

View reviewed changes

discovery-infra/bootstrap_in_place.py Outdated Show resolved Hide resolved

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 30, 2020

osherdp force-pushed the test/bootstrap-in-place branch from 89b55f8 to 18e846a Compare December 30, 2020 19:04

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 30, 2020

MGMT-3108: Adding bootstrap-in-place installation support

bd8aabf

osherdp force-pushed the test/bootstrap-in-place branch from 18e846a to bd8aabf Compare December 30, 2020 19:05

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 30, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 31, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 31, 2020

eranco74 approved these changes Dec 31, 2020

View reviewed changes

openshift-ci-robot assigned eranco74 Dec 31, 2020

openshift-merge-robot merged commit 3699dc8 into openshift:master Dec 31, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MGMT-3108: Adding bootstrap-in-place installation support #360

MGMT-3108: Adding bootstrap-in-place installation support #360

osherdp commented Dec 24, 2020

romfreiman Dec 24, 2020

osherdp commented Dec 27, 2020

tsorya commented Dec 27, 2020

osherdp commented Dec 30, 2020

osherdp commented Dec 30, 2020

tsorya Dec 30, 2020

tsorya Dec 30, 2020

tsorya Dec 30, 2020

osherdp Dec 30, 2020

tsorya Dec 30, 2020

tsorya Dec 30, 2020

eranco74 Dec 31, 2020

tsorya commented Dec 30, 2020

tsorya commented Dec 31, 2020

osherdp commented Dec 31, 2020

eranco74 Dec 31, 2020

eranco74 Dec 31, 2020

osherdp Dec 31, 2020

openshift-ci-robot commented Dec 31, 2020

openshift-bot commented Dec 31, 2020



		def gather_sosreport_data(host_ip):
		with SshConnection(ip=host_ip, private_ssh_key_path=SSH_KEY) as ssh:

MGMT-3108: Adding bootstrap-in-place installation support #360

MGMT-3108: Adding bootstrap-in-place installation support #360

Conversation

osherdp commented Dec 24, 2020

Choose a reason for hiding this comment

osherdp commented Dec 27, 2020

tsorya commented Dec 27, 2020

osherdp commented Dec 30, 2020

osherdp commented Dec 30, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tsorya commented Dec 30, 2020

tsorya commented Dec 31, 2020

osherdp commented Dec 31, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

openshift-ci-robot commented Dec 31, 2020

openshift-bot commented Dec 31, 2020