-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-ISSUE: Update README with testing image instructions, TOC #2638
base: master
Are you sure you want to change the base?
Conversation
@yoavsc0302: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yoavsc0302 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@yoavsc0302: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@@ -375,10 +381,63 @@ make kill_all_port_forwardings | |||
|
|||
## Test `assisted-service` image | |||
|
|||
### Initial Deployment with Custom Image | |||
|
|||
```bash | |||
make destroy run SERVICE=<image to test> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably work without destroy
no ?
```bash | ||
make destroy run SERVICE=<image to test> | ||
``` | ||
|
||
### Updating a running `assisted-service` deployment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe these instructions should be located in some file called dev.md
or something similar. This README.md
is too long already. Maybe we can add a pre-issue to this issue about splitting the README.md
file to multiple files inside a docs
directory ? @AlonaKaplan WDYT ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can have a ref from here to another file to avoid this README to be even longer.
Description
This PR updates the
README.md
file with the following improvements:assisted-service
image in a running deployment:oc set image
to update the deployment.oc rollout restart
andoc delete pods
.Why?
assisted-service
image in a running environment.