Mgmt-19419: replace HighAvailabilityMode with ControlPlaneCount - phase 1 #2632
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
/cc: @danmanor |
openshift-ci
bot
added
the
size/M
andrej1991
force-pushed
the
MGMT-19419
branch
3 times, most recently
from
aa7a8e5 to
a063420
Compare
andrej1991
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@andrej1991: This pull request references Mgmt-19419 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
andrej1991
force-pushed
the
MGMT-19419
branch
from
a063420 to
4883d33
Compare
| # if self.nodes.masters_count and self.nodes.masters_count > 3: | ||
| # extra_vars["control_plane_count"] = self.nodes.masters_count |
There was a problem hiding this comment.
please remove if it's not needed
| @@ -95,7 +95,8 @@ class _EnvVariables(DataPool, ABC): | |||
| loader=lambda x: bool(strtobool(x)), | |||
| default=env_defaults.DEFAULT_USER_MANAGED_NETWORKING, | |||
| ) | |||
| high_availability_mode: EnvVar = EnvVar(default=env_defaults.DEFAULT_HIGH_AVAILABILITY_MODE) | |||
| control_plane_count: EnvVar = EnvVar(default=env_defaults.DEFAULT_CONTROL_PLANE_COUNT) | |||
| high_availability_mode: EnvVar = EnvVar(default=consts.HighAvailabilityMode.FULL) | |||
There was a problem hiding this comment.
don't we want to remove high_availability_mode, since you seem to use control_plane_count everywhere now?
Makefile
Outdated
| @@ -23,7 +23,7 @@ SKIPPER_PARAMS ?= -i | |||
|
|
|||
| ASSISTED_SERVICE_HOST := $(or ${ASSISTED_SERVICE_HOST},$(shell hostname)) | |||
|
|
|||
| # Openshift CI params | |||
| # Openshift CI params | |||
There was a problem hiding this comment.
| # Openshift CI params | |
| # Openshift CI params |
nit
|
/cc @danmanor |
andrej1991
force-pushed
the
MGMT-19419
branch
from
4883d33 to
34b46e6
Compare
|
@andrej1991: This pull request references Mgmt-19419 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
andrej1991
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
openshift-ci
bot
added
lgtm
…h assisted-service
andrej1991
force-pushed
the
MGMT-19419
branch
from
34b46e6 to
cd286bf
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriengentil, andrej1991 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@andrej1991: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
MGMT-19419: it is the first phase of replacing HighAvailabilityMode with ControlPlaneCount. At the moment because assisted-service still uses high-availability-mode some references needs to be kept so the deployment would work.
It depends on openshift/assisted-installer-agent#911.