Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Remove deletion of control_plane_count field during cluster creation #2584

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

danmanor
Copy link
Contributor

@danmanor danmanor commented Dec 2, 2024

Remove deletion of control_plane_count field during cluster creation as it was replaced in #2569 to conditionally adding this field

@openshift-ci-robot
Copy link

@danmanor: This pull request explicitly references no jira issue.

In response to this:

NO-ISSUE: Remove deletion of control_plane_count field during cluster creation as it was replaced in #2569 to conditionally adding this field

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 2, 2024
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 2, 2024
@openshift-ci openshift-ci bot requested review from eliorerz and tsorya December 2, 2024 09:38
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2024
@danmanor
Copy link
Contributor Author

danmanor commented Dec 2, 2024

/override ci/prow/e2e-metal-assisted-kube-api-late-binding-single-node

Copy link

openshift-ci bot commented Dec 2, 2024

@danmanor: Overrode contexts on behalf of danmanor: ci/prow/e2e-metal-assisted-kube-api-late-binding-single-node

In response to this:

/override ci/prow/e2e-metal-assisted-kube-api-late-binding-single-node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2024
Copy link

openshift-ci bot commented Dec 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil, danmanor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adriengentil,danmanor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 798a2ea and 2 for PR HEAD 9e1ac2f in total

@danmanor
Copy link
Contributor Author

danmanor commented Dec 2, 2024

/override ci/prow/e2e-metal-assisted-kube-api-late-binding-single-node

Copy link

openshift-ci bot commented Dec 2, 2024

@danmanor: Overrode contexts on behalf of danmanor: ci/prow/e2e-metal-assisted-kube-api-late-binding-single-node

In response to this:

/override ci/prow/e2e-metal-assisted-kube-api-late-binding-single-node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Dec 2, 2024

@danmanor: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit c48d89f into openshift:master Dec 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants