Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-17556: Add network to clean os boot data #2567

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

bkopilov
Copy link
Contributor

Libvirt allows to boot from network and set order per interface with When try to add support for boot order when disk exists it rejected by libvirt: unsupported configuration: per-device boot elements cannot be used together with os/boot elements

Adding support to clean network from os boot and from interfaces.

In case of boot from iSCSI we must add the provision interface as primary interface to boot from.

Libvirt allows to boot from network and set order per interface with <boot order= />
When try to add support for boot order when disk exists it rejected by libvirt:
unsupported configuration: per-device boot elements cannot be used together with os/boot elements

Adding support to clean network from os boot and from interfaces.

In case of boot from iSCSI we must add the provision interface as primary interface to boot from.
@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 17, 2024
Copy link

openshift-ci bot commented Nov 17, 2024

Hi @bkopilov. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bkopilov
Copy link
Contributor Author

@adriengentil

@bkopilov bkopilov changed the title Add network to clean os boot data [MGMT-17556] Add network to clean os boot data Nov 17, 2024
@adriengentil
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 20, 2024
@adriengentil
Copy link
Contributor

adriengentil commented Nov 20, 2024

@bkopilov title must be in the following format:
/retitle MGMT-17556: Add network to clean os boot data

@openshift-ci openshift-ci bot changed the title [MGMT-17556] Add network to clean os boot data MGMT-17556: Add network to clean os boot data Nov 20, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 20, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 20, 2024

@bkopilov: This pull request references MGMT-17556 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set.

In response to this:

Libvirt allows to boot from network and set order per interface with When try to add support for boot order when disk exists it rejected by libvirt: unsupported configuration: per-device boot elements cannot be used together with os/boot elements

Adding support to clean network from os boot and from interfaces.

In case of boot from iSCSI we must add the provision interface as primary interface to boot from.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2024
Copy link

openshift-ci bot commented Nov 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil, bkopilov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2024
Copy link

openshift-ci bot commented Nov 20, 2024

@bkopilov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-assisted-kube-api-late-binding-single-node cd4c25f link false /test e2e-metal-assisted-kube-api-late-binding-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit aaa9c7e into openshift:master Nov 20, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants