-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-17556: Add network to clean os boot data #2567
MGMT-17556: Add network to clean os boot data #2567
Conversation
Libvirt allows to boot from network and set order per interface with <boot order= /> When try to add support for boot order when disk exists it rejected by libvirt: unsupported configuration: per-device boot elements cannot be used together with os/boot elements Adding support to clean network from os boot and from interfaces. In case of boot from iSCSI we must add the provision interface as primary interface to boot from.
Hi @bkopilov. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
@bkopilov title must be in the following format: |
@bkopilov: This pull request references MGMT-17556 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriengentil, bkopilov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@bkopilov: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
aaa9c7e
into
openshift:master
Libvirt allows to boot from network and set order per interface with When try to add support for boot order when disk exists it rejected by libvirt: unsupported configuration: per-device boot elements cannot be used together with os/boot elements
Adding support to clean network from os boot and from interfaces.
In case of boot from iSCSI we must add the provision interface as primary interface to boot from.