Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enable redirect to console for classes inherit from BaseTest #2539

Closed
wants to merge 1 commit into from

Conversation

bkopilov
Copy link
Contributor

Current code does not support kernel_arguments cosole for node when running virsh console.

Added support for class decorator enabled by request on BaseTest childs The decorator check all test_ function and add parametrize kernel_arguments without change the functions signature.
Added hook to cluster fixture to enable kernel_arguments params.

Current code does not support kernel_arguments cosole for node when
running virsh console.

Added support for class decorator enabled by request on BaseTest childs
The decorator check all test_ function and add parametrize kernel_arguments
without change the functions signature.
Added hook to cluster fixture to enable kernel_arguments params.
@openshift-ci openshift-ci bot requested review from rccrdpccl and tsorya September 28, 2024 07:26
Copy link

openshift-ci bot commented Sep 28, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bkopilov
Once this PR has been reviewed and has the lgtm label, please assign adriengentil for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 28, 2024
Copy link

openshift-ci bot commented Sep 28, 2024

Hi @bkopilov. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 28, 2024
@bkopilov
Copy link
Contributor Author

@eifrach , @adriengentil , @AlonaKaplan
I am trying the fix on test_infra test , already tested on kni-test-infra.
It will allow us to enable console redirect on all class functions without code change.

@eifrach
Copy link
Contributor

eifrach commented Sep 29, 2024

hey @bkopilov thanks for the contribute,
I think that we shouldn’t pytest inside util’s - also we can just add a simple addition to the kernel args which I think will be much more easier to maintain and readable

Here is an example of an API call
https://github.com/eifrach/ansible-nvidia-sno/blob/main/roles/assisted-sno/tasks/03_host_deployment.yml#L45-L59

which applies this manifest
https://github.com/eifrach/ansible-nvidia-sno/blob/main/roles/assisted-sno/templates/99_master_kernel_arg.j2

@bkopilov
Copy link
Contributor Author

yes make sense

@bkopilov bkopilov closed this Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants