Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-ISSUE: netaddr package rollback do to breaking changes #2398

Merged
merged 1 commit into from
Mar 13, 2024
Merged

NO-ISSUE: netaddr package rollback do to breaking changes #2398

merged 1 commit into from
Mar 13, 2024

Conversation

eifrach
Copy link
Contributor

@eifrach eifrach commented Mar 13, 2024

netaddr remove support for is_private function.
reveting version and blocking packge update.

will revert after fix in ansible utils
ansible-collections/ansible.utils#331

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 13, 2024
@openshift-ci-robot
Copy link

@eifrach: This pull request explicitly references no jira issue.

In response to this:

netaddr remove support for is_private function.
reveting version and blocking packge update.

will revert after fix in ansible utils
ansible-collections/ansible.utils#331

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eifrach
Copy link
Contributor Author

eifrach commented Mar 13, 2024

/test ?

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 13, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 13, 2024

@eifrach: The following commands are available to trigger required jobs:

  • /test e2e-metal-assisted
  • /test e2e-metal-assisted-bond-4-14
  • /test e2e-metal-assisted-kube-api-net-suite
  • /test e2e-metal-assisted-static-ip-suite-4-14
  • /test e2e-metal-single-node-live-iso
  • /test e2e-metal-single-node-with-worker-live-iso
  • /test images
  • /test lint

The following commands are available to trigger optional jobs:

  • /test e2e-metal-assisted-4-11
  • /test e2e-metal-assisted-4-12
  • /test e2e-metal-assisted-4-13
  • /test e2e-metal-assisted-4-14
  • /test e2e-metal-assisted-4-15
  • /test e2e-metal-assisted-bond
  • /test e2e-metal-assisted-cnv
  • /test e2e-metal-assisted-day2
  • /test e2e-metal-assisted-day2-arm-workers
  • /test e2e-metal-assisted-day2-single-node
  • /test e2e-metal-assisted-external
  • /test e2e-metal-assisted-external-4-14
  • /test e2e-metal-assisted-ha-kube-api
  • /test e2e-metal-assisted-ha-kube-api-ipv4
  • /test e2e-metal-assisted-ha-kube-api-ipv6
  • /test e2e-metal-assisted-ipv4v6
  • /test e2e-metal-assisted-ipv6
  • /test e2e-metal-assisted-ipxe
  • /test e2e-metal-assisted-kube-api-late-binding-single-node
  • /test e2e-metal-assisted-kube-api-late-unbinding-single-node
  • /test e2e-metal-assisted-kube-api-reclaim
  • /test e2e-metal-assisted-kube-api-reclaim-single-node
  • /test e2e-metal-assisted-lvm
  • /test e2e-metal-assisted-mce
  • /test e2e-metal-assisted-mce-sno
  • /test e2e-metal-assisted-metallb
  • /test e2e-metal-assisted-none
  • /test e2e-metal-assisted-odf
  • /test e2e-metal-assisted-onprem
  • /test e2e-metal-assisted-single-node
  • /test e2e-metal-assisted-static-ip-suite
  • /test e2e-metal-assisted-tang
  • /test e2e-metal-assisted-tpmv2
  • /test e2e-metal-assisted-upgrade-agent
  • /test e2e-nutanix-assisted
  • /test e2e-nutanix-assisted-4-13
  • /test e2e-nutanix-assisted-4-14
  • /test e2e-oci-assisted
  • /test e2e-oci-assisted-4-14
  • /test e2e-oci-assisted-iscsi
  • /test e2e-vsphere-assisted
  • /test e2e-vsphere-assisted-4-12
  • /test e2e-vsphere-assisted-4-13
  • /test e2e-vsphere-assisted-4-14
  • /test e2e-vsphere-assisted-kube-api
  • /test e2e-vsphere-assisted-umn
  • /test opct-oci-assisted

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted
  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-kube-api-late-binding-single-node
  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-kube-api-net-suite
  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-single-node-live-iso
  • pull-ci-openshift-assisted-test-infra-master-images
  • pull-ci-openshift-assisted-test-infra-master-lint

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eifrach
Copy link
Contributor Author

eifrach commented Mar 13, 2024

/test e2e-metal-assisted-day2-arm-workers

@eifrach
Copy link
Contributor Author

eifrach commented Mar 13, 2024

/cc @adriengentil

adriengentil
adriengentil approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@adriengentil adriengentil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
waiting for arm job to complete

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil, eifrach

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adriengentil,eifrach]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 13, 2024

@eifrach: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@eifrach
Copy link
Contributor Author

eifrach commented Mar 13, 2024

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 6c2e320 into openshift:master Mar 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriengentil adriengentil adriengentil approved these changes

@omertuc omertuc Awaiting requested review from omertuc

@tsorya tsorya Awaiting requested review from tsorya

Assignees

@adriengentil adriengentil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eifrach @openshift-ci-robot @adriengentil