Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGMT-15088: Add multi VIP support #2294

Merged
merged 1 commit into from
Nov 10, 2023
Merged

MGMT-15088: Add multi VIP support #2294

merged 1 commit into from
Nov 10, 2023

Conversation

nmagnezi
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 17, 2023
@openshift-ci openshift-ci bot requested review from eifrach and eranco74 October 17, 2023 09:57
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 17, 2023
@nmagnezi nmagnezi changed the title WIP: Add multi VIP support MGMT-15088: Add multi VIP support Oct 18, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 18, 2023 •
edited by openshift-ci bot
Loading

@nmagnezi: This pull request references MGMT-15088 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 18, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 18, 2023
@nmagnezi nmagnezi force-pushed the vips branch 4 times, most recently from 526f590 to b7c6316 Compare October 23, 2023 14:09
@nmagnezi nmagnezi force-pushed the vips branch 6 times, most recently from 2b5bd84 to dab9e3c Compare November 7, 2023 18:56
@nmagnezi
Copy link
Contributor Author

nmagnezi commented Nov 8, 2023

/test ?

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 8, 2023

@nmagnezi: The following commands are available to trigger required jobs:

  • /test e2e-metal-assisted
  • /test e2e-metal-assisted-kube-api-net-suite
  • /test e2e-metal-single-node-with-worker-live-iso
  • /test images
  • /test lint

The following commands are available to trigger optional jobs:

  • /test e2e-metal-assisted-4-10
  • /test e2e-metal-assisted-4-11
  • /test e2e-metal-assisted-4-12
  • /test e2e-metal-assisted-4-13
  • /test e2e-metal-assisted-4-14
  • /test e2e-metal-assisted-4-9
  • /test e2e-metal-assisted-bond
  • /test e2e-metal-assisted-cnv
  • /test e2e-metal-assisted-day2
  • /test e2e-metal-assisted-day2-arm-workers
  • /test e2e-metal-assisted-day2-single-node
  • /test e2e-metal-assisted-ha-kube-api
  • /test e2e-metal-assisted-ha-kube-api-ipv4
  • /test e2e-metal-assisted-ha-kube-api-ipv6
  • /test e2e-metal-assisted-ipv4v6
  • /test e2e-metal-assisted-ipv6
  • /test e2e-metal-assisted-ipxe
  • /test e2e-metal-assisted-kube-api-late-binding-single-node
  • /test e2e-metal-assisted-kube-api-late-unbinding-single-node
  • /test e2e-metal-assisted-kube-api-reclaim
  • /test e2e-metal-assisted-kube-api-reclaim-single-node
  • /test e2e-metal-assisted-lvm
  • /test e2e-metal-assisted-mce
  • /test e2e-metal-assisted-mce-sno
  • /test e2e-metal-assisted-metallb
  • /test e2e-metal-assisted-none
  • /test e2e-metal-assisted-odf
  • /test e2e-metal-assisted-onprem
  • /test e2e-metal-assisted-prod
  • /test e2e-metal-assisted-single-node
  • /test e2e-metal-assisted-static-ip-suite
  • /test e2e-metal-assisted-tang
  • /test e2e-metal-assisted-tpmv2
  • /test e2e-metal-assisted-upgrade-agent
  • /test e2e-metal-single-node-live-iso
  • /test e2e-nutanix-assisted
  • /test e2e-nutanix-assisted-4-13
  • /test e2e-oci-assisted
  • /test e2e-vsphere-assisted
  • /test e2e-vsphere-assisted-4-12
  • /test e2e-vsphere-assisted-4-13
  • /test e2e-vsphere-assisted-kube-api
  • /test e2e-vsphere-assisted-umn

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted
  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-bond
  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-ipv4v6
  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-ipv6
  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-kube-api-late-binding-single-node
  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-kube-api-net-suite
  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-none
  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-static-ip-suite
  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-single-node-live-iso
  • pull-ci-openshift-assisted-test-infra-master-images
  • pull-ci-openshift-assisted-test-infra-master-lint

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nmagnezi nmagnezi force-pushed the vips branch 5 times, most recently from d159ec1 to 5007aeb Compare November 8, 2023 12:26
@nmagnezi nmagnezi force-pushed the vips branch 5 times, most recently from d54064c to 285556a Compare November 9, 2023 11:15
rccrdpccl
rccrdpccl reviewed Nov 9, 2023
View reviewed changes
src/assisted_test_infra/test_infra/controllers/node_controllers/terraform_controller.py Outdated
Comment on lines 187 to 195
if self._config.api_vips:
tfvars["api_vips"] = [i.get("ip") for i in self._config.api_vips]
else:
tfvars["api_vips"] = [i.get("ip") for i in vips["api_vips"]]

if self._config.ingress_vips:
tfvars["ingress_vips"] = [i.get("ip") for i in self._config.ingress_vips]
else:
tfvars["ingress_vips"] = [i.get("ip") for i in vips["ingress_vips"]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should we encapsulate this logic in some helper methods/functions? i.e. tfavars["api_vips"] = get_api_vips(vips)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done as a single function for both

@rccrdpccl
Copy link
Contributor

/retest

@rccrdpccl
Copy link
Contributor

/lgtm
/approve

@adriengentil could you please take a look even if it's merged 🙏 ?

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nmagnezi, rccrdpccl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e019cdb and 2 for PR HEAD 76f7988 in total

@nmagnezi
Copy link
Contributor Author

nmagnezi commented Nov 9, 2023

/retest

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2023
@rccrdpccl
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 6fb0023 into openshift:master Nov 10, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 10, 2023

@nmagnezi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-single-node-live-iso 23e954b link false /test e2e-metal-single-node-live-iso

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rccrdpccl rccrdpccl rccrdpccl left review comments

@eifrach eifrach Awaiting requested review from eifrach

@eranco74 eranco74 Awaiting requested review from eranco74

Assignees

@rccrdpccl rccrdpccl

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nmagnezi @openshift-ci-robot @rccrdpccl