-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-15945: Pull service and index images from ocm-2.9 tag #2287
MGMT-15945: Pull service and index images from ocm-2.9 tag #2287
Conversation
@adriengentil: This pull request references MGMT-15945 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@adriengentil: This pull request references MGMT-15945 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -35,9 +35,9 @@ CONTAINER_RUNTIME_COMMAND := $(or ${CONTAINER_COMMAND}, ${CONTAINER_RUNTIME_COMM | |||
LINT_CODE_STYLING_DIRS := src/tests src/triggers src/assisted_test_infra/test_infra src/assisted_test_infra/download_logs src/service_client src/consts src/virsh_cleanup src/cli | |||
|
|||
# assisted-service | |||
SERVICE := $(or $(SERVICE), quay.io/edge-infrastructure/assisted-service:latest) | |||
SERVICE := $(or $(SERVICE), quay.io/edge-infrastructure/assisted-service:ocm-2.9) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fix should only be relevant for local testing, right?
Because in prow we should substitute the image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By experience, I know it breaks the late binding job, but that makes me think we removed the periodic 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, #2138 the issue is mostly with the index
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriengentil, osherdp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
By default in release-ocm-2.9 branch, pull ocm-2.9 tag for service and index images.