Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-14094: Manage case when no resources are found in OCI #2272

Merged

Conversation

adriengentil
Copy link
Contributor

Check that a state file was generated by the import process. When no
state file is present, it means no resources were found in the
compartment.

Exclude network load blancer backend, backend_set and listener resources
from deletion as they will be deleted when the parent LB is deleted.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 22, 2023

@adriengentil: This pull request references MGMT-14094 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Check that a state file was generated by the import process. When no
state file is present, it means no resources were found in the
compartment.

Exclude network load blancer backend, backend_set and listener resources
from deletion as they will be deleted when the parent LB is deleted.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 22, 2023
@adriengentil
Copy link
Contributor Author

/cc @rccrdpccl @osherdp

@openshift-ci openshift-ci bot requested review from osherdp and rccrdpccl September 22, 2023 14:13
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 22, 2023
@openshift-ci openshift-ci bot requested a review from eranco74 September 22, 2023 14:13
@openshift-ci
Copy link

openshift-ci bot commented Sep 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Check that a state file was generated by the import process. When no
state file is present, it means no resources were found in the
compartment.

Exclude network load blancer backend, backend_set and listener resources
from deletion as they will be deleted when the parent LB is deleted.
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2023
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 22, 2023
@rccrdpccl
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2023
@openshift-merge-robot openshift-merge-robot merged commit 447ab27 into openshift:master Sep 22, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 22, 2023

@adriengentil: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-single-node-live-iso 6b79d3e link false /test e2e-metal-single-node-live-iso

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants