Add support to update iso file for set_boot_order #2216
Conversation
openshift-ci
bot
added
the
size/S
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @bkopilov. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
|
@adriengentil: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-nutanix-assisted |
|
/retest |
openshift-ci
bot
added
lgtm
src/assisted_test_infra/test_infra/controllers/node_controllers/libvirt_controller.py
Outdated
Show resolved
Hide resolved
src/assisted_test_infra/test_infra/controllers/node_controllers/node_controller.py
Outdated
Show resolved
Hide resolved
|
/lgtm cancel |
src/assisted_test_infra/test_infra/controllers/node_controllers/nutanix_controller.py
Outdated
Show resolved
Hide resolved
openshift-ci
bot
added
the
do-not-merge/hold
bkopilov
force-pushed
the
iso_image_per_node
branch
from
0cbe084 to
2a86e68
Compare
Added iso file path when user change the boot order.
It will allow us in a cluster to boot nodes with different iso files
uscases:
- Day2 master must be in the same network as day1 masters, we can re-use
one of the existing nodes to become a day2 master by overriding iso file
- Static network changes requires to download the iso again but we dont want
to override all nodes iso path
- Validate re-download iso file when different configurations (proxy)
- Add support for re-usable nodes plus check how we manage multiple iso in
a cluster deployment
In case we want to re-use the node with same network params.
node.set_boot_order(cd_first=True, cdrom_iso_path="/tmp/test.iso)
node.start()
bkopilov
force-pushed
the
iso_image_per_node
branch
from
2a86e68 to
5a6cf5e
Compare
|
Hi Elior , |
I know, our approach on that is if we touch some code that is not annotated we add the annotation in the relevant PR. anyway, we usually not blocking PRs on those stuff. |
|
/retest |
|
/test e2e-vsphere-assisted e2e-nutanix-assisted-4.13 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriengentil, bkopilov, eliorerz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@bkopilov: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/override ci/prow/e2e-metal-assisted-ipv4v6 |
|
@eliorerz: Overrode contexts on behalf of eliorerz: ci/prow/e2e-metal-assisted-ipv4v6 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
Added iso file path when user change the boot order. It will allow us in a cluster to boot nodes with different iso files uscases:
In case we want to re-use the node with same network params. node.set_boot_order(cd_first=True, cdrom_iso_path="/tmp/test.iso) node.start()