Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGMT-9682: fix disk sizes used in various places #1647

Merged
merged 1 commit into from
May 10, 2022
Merged

MGMT-9682: fix disk sizes used in various places #1647

merged 1 commit into from
May 10, 2022

Conversation

osherdp
Copy link
Contributor

@osherdp osherdp commented May 8, 2022 •
edited by openshift-ci bot
Loading

It seems like lots of places are using GiB (Gibibyte == 2 ** 30) whereas requirements in OCP documentation are mentioned in GB (Gigabyte == 10 ** 9) quantities.

This only seems to be applied to the usage rather than the restrictions (that use the proper quantities).

Connected to MGMT-9682 effort.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 8, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 8, 2022

@osherdp: GitHub didn't allow me to request PR reviews from the following users: osherdp.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

It seems like lots of places are using GiB (Gibibyte == 2 ** 30) whereas requirements in OCP documentation are mentioned in GB (Gigabyte == 10 ** 9) quantities.

This only seems to be applied to the usage rather than the restrictions (that use the proper quantities).

/cc @osherdp
/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 8, 2022
@osherdp
Copy link
Contributor Author

osherdp commented May 8, 2022

/test e2e-vsphere-assisted

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2022
@osherdp
Copy link
Contributor Author

osherdp commented May 9, 2022

/test ?

@openshift-ci
Copy link

openshift-ci bot commented May 9, 2022

@osherdp: The following commands are available to trigger required jobs:

  • /test e2e-metal-assisted
  • /test e2e-metal-assisted-kube-api-net-suite
  • /test e2e-metal-single-node-live-iso
  • /test e2e-metal-single-node-with-worker-live-iso
  • /test images
  • /test lint

The following commands are available to trigger optional jobs:

  • /test e2e-metal-assisted-4-10
  • /test e2e-metal-assisted-4-6
  • /test e2e-metal-assisted-4-8
  • /test e2e-metal-assisted-4-9
  • /test e2e-metal-assisted-capi
  • /test e2e-metal-assisted-cnv
  • /test e2e-metal-assisted-day2
  • /test e2e-metal-assisted-ha-kube-api
  • /test e2e-metal-assisted-ha-kube-api-ipv4
  • /test e2e-metal-assisted-ha-kube-api-ipv6
  • /test e2e-metal-assisted-ipv4v6
  • /test e2e-metal-assisted-ipv6
  • /test e2e-metal-assisted-ipxe
  • /test e2e-metal-assisted-kube-api-late-binding-single-node
  • /test e2e-metal-assisted-kube-api-late-unbinding-single-node
  • /test e2e-metal-assisted-none
  • /test e2e-metal-assisted-ocs
  • /test e2e-metal-assisted-odf
  • /test e2e-metal-assisted-onprem
  • /test e2e-metal-assisted-prod
  • /test e2e-metal-assisted-single-node
  • /test e2e-metal-assisted-static-ip-suite
  • /test e2e-metal-assisted-tpmv2
  • /test e2e-vsphere-assisted

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted
  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-cnv
  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-ipv4v6
  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-ipv6
  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-kube-api-net-suite
  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-none
  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-ocs
  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-odf
  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-static-ip-suite
  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-single-node-live-iso
  • pull-ci-openshift-assisted-test-infra-master-images
  • pull-ci-openshift-assisted-test-infra-master-lint

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@osherdp
Copy link
Contributor Author

osherdp commented May 9, 2022

/refresh

@osherdp osherdp closed this May 9, 2022
@osherdp osherdp reopened this May 9, 2022
@osherdp osherdp force-pushed the fix/default-disk-sizes branch from de181fa to 9089256 Compare May 9, 2022 08:37
@osherdp
Copy link
Contributor Author

osherdp commented May 9, 2022

/test e2e-metal-asisted-prod

@openshift-ci
Copy link

openshift-ci bot commented May 9, 2022

@osherdp: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-metal-assisted
  • /test e2e-metal-assisted-kube-api-net-suite
  • /test e2e-metal-single-node-live-iso
  • /test e2e-metal-single-node-with-worker-live-iso
  • /test images
  • /test lint

The following commands are available to trigger optional jobs:

  • /test e2e-metal-assisted-4-10
  • /test e2e-metal-assisted-4-6
  • /test e2e-metal-assisted-4-8
  • /test e2e-metal-assisted-4-9
  • /test e2e-metal-assisted-capi
  • /test e2e-metal-assisted-cnv
  • /test e2e-metal-assisted-day2
  • /test e2e-metal-assisted-ha-kube-api
  • /test e2e-metal-assisted-ha-kube-api-ipv4
  • /test e2e-metal-assisted-ha-kube-api-ipv6
  • /test e2e-metal-assisted-ipv4v6
  • /test e2e-metal-assisted-ipv6
  • /test e2e-metal-assisted-ipxe
  • /test e2e-metal-assisted-kube-api-late-binding-single-node
  • /test e2e-metal-assisted-kube-api-late-unbinding-single-node
  • /test e2e-metal-assisted-none
  • /test e2e-metal-assisted-ocs
  • /test e2e-metal-assisted-odf
  • /test e2e-metal-assisted-onprem
  • /test e2e-metal-assisted-prod
  • /test e2e-metal-assisted-single-node
  • /test e2e-metal-assisted-static-ip-suite
  • /test e2e-metal-assisted-tpmv2
  • /test e2e-vsphere-assisted

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted
  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-cnv
  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-ipv4v6
  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-ipv6
  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-kube-api-net-suite
  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-none
  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-ocs
  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-odf
  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-static-ip-suite
  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-single-node-live-iso
  • pull-ci-openshift-assisted-test-infra-master-images
  • pull-ci-openshift-assisted-test-infra-master-lint

In response to this:

/test e2e-metal-asisted-prod

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@osherdp
Copy link
Contributor Author

osherdp commented May 9, 2022

/test e2e-metal-assisted-prod

@osherdp
Copy link
Contributor Author

osherdp commented May 9, 2022

/cc @eliorerz @paul-maidment

@openshift-ci openshift-ci bot requested review from eliorerz and paul-maidment May 9, 2022 11:58
eliorerz
eliorerz reviewed May 9, 2022
View reviewed changes
MGMT-9682: fix disk sizes used in various places
1bc9e58 
It seems like lots of places are using GiB (Gibibyte == 2 ** 30) whereas
requirements in OCP documentation are mentioned with GB (Gigabyte == 10 ** 9)

This only seems to be applied to the usage, rather than the restrictions
(that use the proper units).
@osherdp osherdp force-pushed the fix/default-disk-sizes branch from 9089256 to 1bc9e58 Compare May 9, 2022 14:05
eliorerz
eliorerz approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@eliorerz eliorerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link

openshift-ci bot commented May 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eliorerz, osherdp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2022
@osherdp
Copy link
Contributor Author

osherdp commented May 9, 2022 •
edited
Loading

/test e2e-metal-assisted-cnv e2e-metal-assisted-odf
known to cause some troubles, but trying out anyway

@osherdp
Copy link
Contributor Author

osherdp commented May 9, 2022

/test e2e-metal-assisted-ocs

@osherdp
Copy link
Contributor Author

osherdp commented May 9, 2022

/retest

@osherdp
Copy link
Contributor Author

osherdp commented May 10, 2022

/test e2e-metal-assisted-odf

@osherdp
Copy link
Contributor Author

osherdp commented May 10, 2022

Actually if it passed preflight validations of the assisted-service then this change should be okay
/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 10, 2022
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link

openshift-ci bot commented May 10, 2022

@osherdp: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-single-node-with-worker-live-iso de181fa link true /test e2e-metal-single-node-with-worker-live-iso
ci/prow/e2e-metal-assisted-odf 1bc9e58 link false /test e2e-metal-assisted-odf

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 381238a into openshift:master May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliorerz eliorerz eliorerz approved these changes

@paul-maidment paul-maidment Awaiting requested review from paul-maidment

Assignees

@eliorerz eliorerz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@osherdp @openshift-bot @eliorerz @openshift-merge-robot