Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-ISSUE: remove deprecated client.update_hosts func #1524

Merged
merged 1 commit into from
Mar 13, 2022
Merged

NO-ISSUE: remove deprecated client.update_hosts func #1524

merged 1 commit into from
Mar 13, 2022

Conversation

danielerez
Copy link
Contributor

Removed client.update_hosts func and usage in utils.
Should use update_host instead for fixing day2 flow.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 10, 2022
@danielerez
Copy link
Contributor Author

/cc @eliorerz

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 10, 2022
@eliorerz
Copy link
Contributor

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2022
@eliorerz
Copy link
Contributor

/test e2e-metal-assisted-day2

@eliorerz
Copy link
Contributor

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2022
@osherdp
Copy link
Contributor

osherdp commented Mar 10, 2022

/test e2e-metal-assisted-day2

day2 will probably be broken for a short period of time

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

13 similar comments
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@osherdp
Copy link
Contributor

osherdp commented Mar 11, 2022

/hold
(until live-iso job is fixed)

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2022
@osherdp
Copy link
Contributor

osherdp commented Mar 13, 2022

/test e2e-metal-single-node-live-iso

nmagnezi
nmagnezi reviewed Mar 13, 2022
View reviewed changes
Copy link
Contributor

@nmagnezi nmagnezi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase this PR on master so #1529 gets included in your branch. That might help with the live-iso job issue.

@danielerez
NO-ISSUE: remove deprecated client.update_hosts func
68db7a5 
Removed client.update_hosts func and usage in utils.
Should use update_host instead for fixing day2 flow.
@danielerez danielerez force-pushed the remove_update_hosts branch from 4af2f7e to c051a6a Compare March 13, 2022 08:34
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 13, 2022
@danielerez danielerez force-pushed the remove_update_hosts branch from c051a6a to 68db7a5 Compare March 13, 2022 09:00
@openshift-ci
Copy link

openshift-ci bot commented Mar 13, 2022 •
edited
Loading

@danielerez: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-assisted-day2 4af2f7e link false /test e2e-metal-assisted-day2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 13, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielerez, osherdp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nmagnezi
Copy link
Contributor

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2022
@nmagnezi
Copy link
Contributor

/retest-required

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 0a5c188 into openshift:master Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmagnezi nmagnezi nmagnezi left review comments

@eliorerz eliorerz eliorerz left review comments

@osherdp osherdp osherdp approved these changes

@michaellevy101 michaellevy101 Awaiting requested review from michaellevy101

@tsorya tsorya Awaiting requested review from tsorya

Assignees

@osherdp osherdp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@danielerez @eliorerz @osherdp @openshift-bot @nmagnezi @openshift-merge-robot