Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-ocm-2.4] MGMT-7351 - Move deployment scripts from assisted-service into test-infra scripts #1276

Merged
merged 1 commit into from
Dec 6, 2021
Merged

[release-ocm-2.4] MGMT-7351 - Move deployment scripts from assisted-service into test-infra scripts #1276

merged 1 commit into from
Dec 6, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1262

/assign eliorerz

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 6, 2021
Merged
@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 6, 2021
@openshift-ci openshift-ci bot requested review from eliorerz and tsorya December 6, 2021 10:04
eliorerz
eliorerz approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@eliorerz eliorerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2021
@openshift-ci
Copy link

openshift-ci bot commented Dec 6, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eliorerz, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2021
@openshift-ci
Copy link

openshift-ci bot commented Dec 6, 2021

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-assisted-olm ddff05d link false /test e2e-metal-assisted-olm
ci/prow/system-test-operator ddff05d link false /test system-test-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@eliorerz eliorerz merged commit deb20da into openshift:release-ocm-2.4 Dec 6, 2021
danielerez added a commit to danielerez/assisted-service that referenced this pull request Jan 2, 2022
@danielerez
MGMT-7705: ignore empty OpenshiftVersions
82d5fac 
This PR backports part of openshift#2708.
It is required since we use the new operator scripts also in release-ocm-2.4 branch
of assisted-test-infra: openshift/assisted-test-infra#1276.

I.e. the OPENSHIFT_VERSIONS var should be optional since the operator deployment
script is specifying only OS_IMAGES and RELEASE_IMAGES in release-ocm-2.4 branch
of assisted-test-infra.
@danielerez danielerez mentioned this pull request Jan 2, 2022
Merged
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliorerz eliorerz eliorerz approved these changes

@tsorya tsorya Awaiting requested review from tsorya

Assignees

@eliorerz eliorerz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@openshift-cherrypick-robot @eliorerz