Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGMT-8181: added day2 cloud flow to e2e tests #1234

Merged
merged 1 commit into from
Nov 17, 2021
Merged

MGMT-8181: added day2 cloud flow to e2e tests #1234

merged 1 commit into from
Nov 17, 2021

Conversation

danielerez
Copy link
Contributor

@danielerez danielerez commented Nov 15, 2021 •
edited
Loading

As e2e flows are now invoked using pytest, fixed day2 on cloud flow to accommodate for the new infra:

  • Added test_day2.py - initialize and execute day2_cloud_flow
  • Note: For simplicity, used day2.py mostly as-is. We can rewrite and move its logic into test_day2 later on. Also, should add support for the ocp flow.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 15, 2021
@danielerez
Copy link
Contributor Author

/cc @eliorerz
/cc @osherdp
/cc @yevgeny-shnaidman
/cc @filanov

@danielerez danielerez force-pushed the day2_cloud_e2e branch 2 times, most recently from 17350c2 to 1433a75 Compare November 15, 2021 09:23
osherdp
osherdp suggested changes Nov 15, 2021
View reviewed changes
@danielerez danielerez force-pushed the day2_cloud_e2e branch 2 times, most recently from 5ff8409 to 65b4806 Compare November 15, 2021 17:28
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 15, 2021
@danielerez danielerez requested a review from osherdp November 16, 2021 09:26
eliorerz
eliorerz reviewed Nov 16, 2021
View reviewed changes
@eliorerz
Copy link
Contributor

Note: For simplicity, used day2.py mostly as-is. We can rewrite and move its logic into test_day2 later on. Also, should add support for the ocp flow.

@osherdp What do you think about it?

@eliorerz
Copy link
Contributor

/hold
Lets add day2 job and run it on this PR to verify it's working

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 16, 2021
@osherdp
Copy link
Contributor

osherdp commented Nov 16, 2021

Note: For simplicity, used day2.py mostly as-is. We can rewrite and move its logic into test_day2 later on. Also, should add support for the ocp flow.

@osherdp What do you think about it?

as long as it's a follow-up task and we get right into it, I don't mind first pushing it almost as is
but let's scope it only to one place, e.g. day2.py file and not all changes in this PR

osherdp
osherdp suggested changes Nov 16, 2021
View reviewed changes
@osherdp
Copy link
Contributor

osherdp commented Nov 16, 2021

/hold Lets add day2 job and run it on this PR to verify it's working

good idea, we can add only presubmit job for test-infra for now

@danielerez
Copy link
Contributor Author

Note: For simplicity, used day2.py mostly as-is. We can rewrite and move its logic into test_day2 later on. Also, should add support for the ocp flow.

@osherdp What do you think about it?

as long as it's a follow-up task and we get right into it, I don't mind first pushing it almost as is but let's scope it only to one place, e.g. day2.py file and not all changes in this PR

Sure, will create a task for it that could be prioritized later.

@osherdp
Copy link
Contributor

osherdp commented Nov 16, 2021

I wonder if it already works...
/test e2e-metal-assisted-day2

@openshift-ci
Copy link

openshift-ci bot commented Nov 16, 2021

@osherdp: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-metal-assisted
  • /test e2e-metal-assisted-kube-api
  • /test e2e-metal-single-node-live-iso
  • /test images
  • /test lint

The following commands are available to trigger optional jobs:

  • /test e2e-metal-assisted-ipv4v6
  • /test e2e-metal-assisted-ipv6
  • /test e2e-metal-assisted-kube-api-late-binding-single-node
  • /test e2e-metal-assisted-multi-version
  • /test e2e-metal-assisted-networking
  • /test e2e-metal-assisted-none
  • /test e2e-metal-assisted-none-ipv6
  • /test e2e-metal-assisted-olm
  • /test e2e-metal-assisted-single-node
  • /test system-test-operator

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted
  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-kube-api
  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-kube-api-late-binding-single-node
  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-single-node-live-iso
  • pull-ci-openshift-assisted-test-infra-master-images
  • pull-ci-openshift-assisted-test-infra-master-lint

In response to this:

I wonder if it already works...
/test e2e-metal-assisted-day2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@osherdp
Copy link
Contributor

osherdp commented Nov 16, 2021

/test ?

@openshift-ci
Copy link

openshift-ci bot commented Nov 16, 2021

@osherdp: The following commands are available to trigger required jobs:

  • /test e2e-metal-assisted
  • /test e2e-metal-assisted-kube-api
  • /test e2e-metal-single-node-live-iso
  • /test images
  • /test lint

The following commands are available to trigger optional jobs:

  • /test e2e-metal-assisted-day2
  • /test e2e-metal-assisted-ipv4v6
  • /test e2e-metal-assisted-ipv6
  • /test e2e-metal-assisted-kube-api-late-binding-single-node
  • /test e2e-metal-assisted-multi-version
  • /test e2e-metal-assisted-networking
  • /test e2e-metal-assisted-none
  • /test e2e-metal-assisted-none-ipv6
  • /test e2e-metal-assisted-olm
  • /test e2e-metal-assisted-single-node
  • /test system-test-operator

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted
  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-kube-api
  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-kube-api-late-binding-single-node
  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-single-node-live-iso
  • pull-ci-openshift-assisted-test-infra-master-images
  • pull-ci-openshift-assisted-test-infra-master-lint

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@osherdp
Copy link
Contributor

osherdp commented Nov 16, 2021

/test e2e-metal-assisted-day2

@osherdp
Copy link
Contributor

osherdp commented Nov 16, 2021

/refresh

@osherdp
Copy link
Contributor

osherdp commented Nov 16, 2021

/test e2e-metal-assisted-day2

@osherdp
Copy link
Contributor

osherdp commented Nov 16, 2021 •
edited
Loading

doesn't seem related to those changes, trying to retest
/test e2e-metal-assisted-day2

@osherdp
Copy link
Contributor

osherdp commented Nov 16, 2021

Now it should work
/test e2e-metal-assisted-day2

@eliorerz
Copy link
Contributor

/test e2e-metal-assisted-day2
Want to re-run the test to verify that it's not flaky

@osherdp
Copy link
Contributor

osherdp commented Nov 16, 2021

that's super cool!

@eliorerz
Copy link
Contributor

that's super cool!

Indeed.. 😀

@danielerez
Copy link
Contributor Author

/test e2e-metal-assisted-day2

@danielerez
MGMT-8181: added day2 cloud flow to e2e tests
50b5858 
As e2e flows are now invoked using pytest, fixed day2
on cloud flow to accommodate for the new infra:
* Added test_day2.py - initialize and execute day2_cloud_flow
* Note: For simplicity, used day2.py mostly as-is. We can rewrite
  and move its logic into test_day2 later on. Also, should add support
  for the ocp flow.
@danielerez
Copy link
Contributor Author

/hold Lets add day2 job and run it on this PR to verify it's working

/unhold
day2 job passed :)

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 17, 2021
@openshift-ci
Copy link

openshift-ci bot commented Nov 17, 2021

@danielerez: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-assisted-kube-api-late-binding-single-node 50b5858 link false /test e2e-metal-assisted-kube-api-late-binding-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2021
@openshift-ci
Copy link

openshift-ci bot commented Nov 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielerez, osherdp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2021
@openshift-merge-robot openshift-merge-robot merged commit 086b575 into openshift:master Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliorerz eliorerz eliorerz left review comments

@osherdp osherdp osherdp approved these changes

@filanov filanov Awaiting requested review from filanov

@yevgeny-shnaidman yevgeny-shnaidman Awaiting requested review from yevgeny-shnaidman

@michaellevy101 michaellevy101 Awaiting requested review from michaellevy101

Assignees

@osherdp osherdp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danielerez @eliorerz @osherdp @openshift-merge-robot