[WIP] Support REST API dual-stack #1133
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
@YuviGold: GitHub didn't allow me to request PR reviews from the following users: YuviGold. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
size/XL
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: YuviGold The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test e2e-metal-ipv6 |
|
@YuviGold: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-metal-assisted-ipv6 |
YuviGold
force-pushed
the
restapi-dualstack
branch
from
5e2393c to
2315154
Compare
|
/test e2e-metal-assisted-ipv6 |
YuviGold
force-pushed
the
restapi-dualstack
branch
from
2315154 to
3b1acac
Compare
openshift-ci
bot
added
size/XXL
|
/test e2e-metal-assisted |
YuviGold
force-pushed
the
restapi-dualstack
branch
from
3b1acac to
4359f33
Compare
openshift-ci
bot
added
size/XL
A lot of changes in order to support `IPv4=true IPv6=true`. - Remove env vars for SERVICE_CIDR, CLUSTER_CIDR, CLUSTER_HOST_PREFIX as no one uses them. - Support sending multiple values for `cluster_networks`, `service_networks`, and `machine_networks`. - Add constants for IPv4, IPv6, and IPv4v6 subnets. - Change controllers signatures from `get_machine_cidr` to `get_machine_networks`. - Support provisioning multiple networks via Terraform. Create a `libvirt_network` resource and a dynamic `network_interface` for each machine network available. - Deprecate `provisioning_cidr` network as it is mostly confusing and we would like to be allowed to add/remove networks without indication whether they are primary/secondary in Terraform. - Change assets to work with lists of two fields - `cidrs` and `libvirt_network_interfaces`. Interfaces are named `ai-net<x>-<number>`. The `x` represents the network number and the `number` represents the namespace index.
YuviGold
force-pushed
the
restapi-dualstack
branch
from
4359f33 to
c421c48
Compare
openshift-ci
bot
added
size/XXL
|
@YuviGold: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
This PR was made at the beginning to resolve dual-tack and changed the whole TF for supporting multiple networks instead of the |
A lot of changes in order to support
IPv4=true IPv6=true.no one uses them.
cluster_networks,service_networks, andmachine_networks.get_machine_cidrtoget_machine_networks.Create a
libvirt_networkresource and a dynamicnetwork_interfacefor each machine network available.
provisioning_cidrnetwork as it is mostly confusing and wewould like to be allowed to add/remove networks without indication
whether they are primary/secondary in Terraform.
cidrsandlibvirt_network_interfaces.Interfaces are named
ai-net<x>-<number>. Thexrepresentsthe network number and the
numberrepresents the namespace index./cc @YuviGold